if_vxlan(4): Plug a memory leak
ClosedPublic
Actions

Authored by zlei on Mon, Jul 1, 12:47 PM.

Details

Reviewers

np
kp
glebius

Group Reviewers

network

Commits

rG087f5e08ab5f: if_vxlan(4): Plug a memory leak

Summary

On clone creating, either failure from vxlan_set_user_config() or
ifc_copyin() will result in leaking previous allocated counters.

Since counter_u64_alloc(M_WAITOK) never fails, make vxlan_stats_alloc()
void and move the allocation for counters below checking ifd->params to
avoid memory leak.

Fixes: b092fd6c973d if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Mon, Jul 1, 12:47 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMon, Jul 1, 12:47 PM

zlei requested review of this revision.Mon, Jul 1, 12:47 PM

kp accepted this revision as: kp.Mon, Jul 1, 4:01 PM

kp added a subscriber: kp.

kp added inline comments.

sys/net/if_vxlan.c
2955	counter_u64_free(NULL) is safe (now), so even without the other changes getting rid of the check would be fine.

This revision is now accepted and ready to land.Mon, Jul 1, 4:01 PM

glebius accepted this revision as: glebius.Mon, Jul 1, 9:55 PM

zlei marked an inline comment as done.Tue, Jul 2, 4:53 AM

zlei added inline comments.

sys/net/if_vxlan.c
2955	Indeed.

Closed by commit rG087f5e08ab5f: if_vxlan(4): Plug a memory leak (authored by zlei). · Explain WhyTue, Jul 2, 4:59 AM

This revision was automatically updated to reflect the committed changes.

zlei marked an inline comment as done.

zlei added a commit: rG087f5e08ab5f: if_vxlan(4): Plug a memory leak.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_vxlan.c

36 lines

Diff 140450

View Options

if_vxlan(4): Plug a memory leakClosedPublicActions