Page MenuHomeFreeBSD

if_vxlan(4): Plug a memory leak
ClosedPublic

Authored by zlei on Mon, Jul 1, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 13, 6:15 AM
Unknown Object (File)
Thu, Jul 11, 1:18 PM
Unknown Object (File)
Sun, Jul 7, 2:26 AM
Unknown Object (File)
Sat, Jul 6, 11:58 PM
Unknown Object (File)
Fri, Jul 5, 6:56 PM
Unknown Object (File)
Thu, Jul 4, 8:18 AM
Unknown Object (File)
Thu, Jul 4, 8:10 AM
Unknown Object (File)
Thu, Jul 4, 3:32 AM

Details

Summary

On clone creating, either failure from vxlan_set_user_config() or
ifc_copyin() will result in leaking previous allocated counters.

Since counter_u64_alloc(M_WAITOK) never fails, make vxlan_stats_alloc()
void and move the allocation for counters below checking ifd->params to
avoid memory leak.

Fixes: b092fd6c973d if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Mon, Jul 1, 12:47 PM
kp added a subscriber: kp.
kp added inline comments.
sys/net/if_vxlan.c
2955

counter_u64_free(NULL) is safe (now), so even without the other changes getting rid of the check would be fine.

This revision is now accepted and ready to land.Mon, Jul 1, 4:01 PM
zlei marked an inline comment as done.Tue, Jul 2, 4:53 AM
zlei added inline comments.
sys/net/if_vxlan.c
2955

Indeed.

This revision was automatically updated to reflect the committed changes.
zlei marked an inline comment as done.