Page MenuHomeFreeBSD
Differential D45776

sound: Make DSP_FIXUP_ERROR() regular code
AcceptedPublic
Actions

Authored by christos on Sat, Jun 29, 3:38 PM.

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

No reason to have this as a macro. No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58394
Build 55282: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Jun 29, 3:38 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Jun 29, 3:38 PM
christos requested review of this revision.Sat, Jun 29, 3:38 PM
Harbormaster completed remote builds in B58394: Diff 140359.Sat, Jun 29, 3:38 PM
christos added a parent revision: D45775: sound: Simplify getchns().Sat, Jun 29, 3:38 PM
markj accepted this revision.Sun, Jun 30, 3:30 PM
This revision is now accepted and ready to land.Sun, Jun 30, 3:30 PM
emaste accepted this revision.Mon, Jul 1, 1:28 PM

Expanding this inline LGTM. I wonder if it should be else if though (as a subsequent change)

christos added a comment.Mon, Jul 1, 6:22 PM
In D45776#1044783, @emaste wrote:

Expanding this inline LGTM. I wonder if it should be else if though (as a subsequent change)

I agree with making it an else if. If the open flags are invalid then we don't need to check the second if at all. I think this change can be included in this patch though.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
16 lines

Diff 140359

View Options

sys/dev/sound/pcm/dsp.c

Loading...