tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch
ClosedPublic
Actions

Authored by rlibby on Wed, Jun 26, 7:50 PM.

Details

Reviewers

rrs
tuexen

Group Reviewers

transport

Commits

rGc02a8caf50bb: tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch

Test Plan

make buildkernel on amd64 and i386, examine warnings

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58368
Build 55256: arc lint + arc unit

Event Timeline

rlibby created this revision.Wed, Jun 26, 7:50 PM

Herald added a reviewer: transport. · View Herald TranscriptWed, Jun 26, 7:50 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

rlibby requested review of this revision.Wed, Jun 26, 7:50 PM

rlibby added a parent revision: D45750: nvme: avoid gcc -Werror=int-to-pointer-cast on 32-bit arch.

Harbormaster completed remote builds in B58368: Diff 140282.Wed, Jun 26, 7:50 PM

rlibby added a child revision: D45752: tcp_rack: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch.Wed, Jun 26, 7:51 PM

rlibby edited the test plan for this revision. (Show Details)Wed, Jun 26, 7:55 PM

rlibby added reviewers: rrs, tuexen.

Why is an uint64_t not good enough to hold a pointer? Aren't pointers 32-bit or 64-bit on all architectures FreeBSD supports?

In D45751#1043496, @tuexen wrote:

Why is an uint64_t not good enough to hold a pointer? Aren't pointers 32-bit or 64-bit on all architectures FreeBSD supports?

Yeah, uint64_t is always wide enough. gcc's issue on 32-bit arch is that it doesn't like to see a 32-bit pointer cast directly to a 64-bit integer. It issues -Wpointer-to-int-cast, which is an error with our flags. This patch works around that by first casting to an integer type that is the same width as a pointer. From there there is no complaint about the conversion to uint64_t. The patch is intended to be a functional nop, for both 32-bit and 64-bit arch.

Same deal in D45752. Related issue in reverse in D45750.

tuexen accepted this revision.Wed, Jun 26, 8:51 PM

This revision is now accepted and ready to land.Wed, Jun 26, 8:51 PM

Closed by commit rGc02a8caf50bb: tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch (authored by rlibby). · Explain WhyFri, Jun 28, 3:41 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rGc02a8caf50bb: tcp_bbr: avoid gcc -Werror=pointer-to-int-cast on 32-bit arch.