conf: Add hkbd and hms to GENERIC* kernel configs
ClosedPublic
Actions

Authored by manu on Jun 20 2024, 8:11 AM.

Details

Reviewers

andrew
wulf
imp
emaste

Commits

rG8e908fab6c5b: conf: Add usbhid and hidbus to GENERIC* kernel configs
rG13d00a43cba4: conf: Add usbhid and hidbus to GENERIC* kernel configs

Summary

Include the new unified HID stack by default in generic.
This will allow us to migrate to the multi-stack hkbd and hms instead of
relying on the older ukbd and ums which only work with USB.
To test those drivers just add hw.usb.usbhid.enable=1 in loader.conf

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Jun 20 2024, 8:11 AM

Herald added a reviewer: andrew. · View Herald TranscriptJun 20 2024, 8:11 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

manu requested review of this revision.Jun 20 2024, 8:11 AM

Harbormaster completed remote builds in B58262: Diff 140023.Jun 20 2024, 8:11 AM

manu added a child revision: D45659: Enable usbhid by default.Jun 20 2024, 8:11 AM

manu added a reviewer: wulf.Jun 20 2024, 8:11 AM

Apart from the one mistakenly added hid kernel, I like it. But I hit approve because that mistake predates this change.

sys/powerpc/conf/QORIQ64
130	I don't think this kernel should even have hid at all

This revision is now accepted and ready to land.Jun 20 2024, 2:32 PM

Seems reasonable to me, if we have ukbd compiled in as well. Can you also indicate in the commit message what we get out of using hkbd instead of ukbd?

(Mostly as a thought experiment) would it be possible for these to all be loaded as modules?

jhibbits added inline comments.Jun 20 2024, 6:57 PM

sys/powerpc/conf/QORIQ64
130	I added it because QORIQ64 is most likely to be seen with the AmigaOne X5000 desktop (I did all the book-E work over the past decade or so with that in mind).

In D45658#1041688, @emaste wrote:

Seems reasonable to me, if we have ukbd compiled in as well. Can you also indicate in the commit message what we get out of using hkbd instead of ukbd?

I thought my message was clear on this, can you suggest better wording then ?

(Mostly as a thought experiment) would it be possible for these to all be loaded as modules?

They can but I'm unsure if everything works (same with old uhid stack). If I boot MINIMAL and load usb, uhid and ukbd from loader I still don't have a keyboard, same for loading usb, usbhid and hkbd. So I'm unsure if we have everything correct for runtime loadable usb stack.

gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.Jun 21 2024, 7:34 AM

gehaowu_bitmoe.com removed a subscriber: gehaowu_bitmoe.com.

wulf accepted this revision.Jun 21 2024, 3:52 PM

In D45658#1041770, @manu wrote:

In D45658#1041688, @emaste wrote:

Seems reasonable to me, if we have ukbd compiled in as well. Can you also indicate in the commit message what we get out of using hkbd instead of ukbd?

I thought my message was clear on this, can you suggest better wording then ?

Include the new unified HID stack by default in generic. This will allow us to migrate to the
multi-stack hkbd and hms instead of relying on the older ukbd and ums which only work with
USB.

manu updated this revision to Diff 140158.Jun 24 2024, 4:59 AM

manu retitled this revision from conf: Add usbhid and hidbus to GENERIC* kernel configs to conf: Add hkbd and hms to GENERIC* kernel configs.

manu edited the summary of this revision. (Show Details)

This revision now requires review to proceed.Jun 24 2024, 4:59 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2024, 6:06 AM

Closed by commit rG13d00a43cba4: conf: Add usbhid and hidbus to GENERIC* kernel configs (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG13d00a43cba4: conf: Add usbhid and hidbus to GENERIC* kernel configs.

manu added a commit: rG8e908fab6c5b: conf: Add usbhid and hidbus to GENERIC* kernel configs.Jul 29 2024, 4:37 PM