Page MenuHomeFreeBSD

pf: always mark states as unlinked before detaching them
ClosedPublic

Authored by kp on May 6 2024, 2:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 6:29 PM
Unknown Object (File)
Sat, Jun 8, 12:00 AM
Unknown Object (File)
Sun, May 26, 7:02 AM
Unknown Object (File)
Fri, May 24, 7:01 AM
Unknown Object (File)
Mon, May 20, 12:14 PM
Unknown Object (File)
May 8 2024, 8:52 PM
Unknown Object (File)
May 8 2024, 1:48 PM
Unknown Object (File)
May 7 2024, 11:54 PM

Details

Summary

Users have reported crashes in pf_test_state_udp() where at least one state key
is NULL.

That suggests that pf_detach_state() ran concurrently with pf_test_state_udp().
pf_test_state_udp() holds the state lock (aka the id lock), but
pf_detach_state() does not.
The intent is that detached states are not returned by STATE_LOOKUP/
pf_find_state(), as the state's timeout is set to PFTM_UNLINKED and thus
pf_find_state() does not find the state.

There are other paths to pf_detach_state() (outside of pf_unlink_state())
though, where we did not set the timeout to PFTM_UNLINKED. Fix those, and assert
that the timeout is set correctly when we enter pf_detach_state().

MFC after: 1 week
See also: https://redmine.pfsense.org/issues/15413
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57598
Build 54486: arc lint + arc unit