sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock()
ClosedPublic
Actions

Authored by christos on Apr 28 2024, 3:46 PM.

Details

Reviewers

markj
emaste

Commits

rG9847c2497d2b: sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock()
rGb18b990d8e7b: sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock()

Summary

Make sure that the softc doesn't become NULL in between the checks.

Sponsored by: The FreeBSD Foundation
MFC after; 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Apr 28 2024, 3:46 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 28 2024, 3:46 PM

christos requested review of this revision.Apr 28 2024, 3:46 PM

Harbormaster completed remote builds in B57423: Diff 137774.Apr 28 2024, 3:46 PM

christos added a parent revision: D44924: sound: Fix NULL dereference in dsp_clone() and mixer_clone().Apr 28 2024, 3:46 PM

Make sure that the softc doesn't become NULL in between the checks.

Well, the problem is that the softc might be freed in between the checks.

This revision is now accepted and ready to land.Apr 28 2024, 4:02 PM

Closed by commit rGb18b990d8e7b: sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock() (authored by christos). · Explain WhyApr 28 2024, 7:49 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGb18b990d8e7b: sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock().

christos added a commit: rG9847c2497d2b: sound: Wrap dsp_clone() and mixer_clone() with bus_topo_lock().Apr 29 2024, 10:45 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

dsp.c

2 lines

mixer.c

2 lines

Diff 137791

View Options

sys/dev/sound/pcm/dsp.c