PR: 276736
Approved by: jrm (mentor), otis (mentor), ale
Tested by: jonc@chen.org.nz
Details
Details
- Reviewers
jrm otis ale brnrd - Commits
- R11:145858d18e57: www/tomcat-native2: new port
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks. Looks good. Could you also run it through something like portlint -AC and portclippy/portfmt?
Comment Actions
One important thing to note: I could bring back OpenSSL 1.1.1 support with a simple patch because
- https://bz.apache.org/bugzilla/show_bug.cgi?id=66667 has not been solved
- It is almost only:
commit 2e23d2c0fc339a3161fdeef92d2740c3884cc22d (HEAD -> main) Author: Michael Osipov <michaelo@apache.org> Date: 2024-04-17T15:51:40+02:00 Revert "Map the OpenSSL 3.x FIPS behaviour to the 1.x API" This reverts commit 101eda32be49559cc75622cb15fbfd128e02572a.
Outcome:
osipovmi@deblndw011x:~/var/Projekte/tomcat-native (main %>) $ ldd ./native/.libs/libtcnative-2.so ./native/.libs/libtcnative-2.so: libssl.so.111 => /usr/lib/libssl.so.111 (0x1d8ee8ddf000) libcrypto.so.111 => /lib/libcrypto.so.111 (0x1d8ee745c000) libapr-1.so.0 => /usr/local/lib/libapr-1.so.0 (0x1d8ee781a000) libcrypt.so.5 => /lib/libcrypt.so.5 (0x1d8ee825b000) libthr.so.3 => /lib/libthr.so.3 (0x1d8ee9507000) libc.so.7 => /lib/libc.so.7 (0x1d8ee366b000)
Comment Actions
I did:
osipovmi@deblndw011x:~/var/Projekte/freebsd/ports/www/tomcat-native2 (pr-276736 <>) $ portlint -AC WARN: Makefile: [30]: BROKEN messages should begin with a lowercase letter and end without a period. WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. WARN: Makefile: "BROKEN_SSL" has to appear earlier. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 4 warnings found.
The only viable thing I could try is WARN: Makefile: "BROKEN_SSL" has to appear earlier.. The rest is out of my control basically.
Comment Actions
Improved version which also supports OpenSSL 1.1.1 by reverting a few changes
from Tomcat Native. Ran full Tomcat test suites, all tests pass.