Convert jls to use libxo
ClosedPublic
Actions

Authored by • rodrigc on Dec 9 2015, 4:10 AM.

Details

Reviewers

jamie
allanjude
marcel
bapt

Group Reviewers

manpages

Commits

rS292580: Add libxo support to jls

Summary

This was originally submitted under PR 200746.
I modified the patch slightly based on my
experience reviewing allanjude's conversion of procstat to libxo.

Test Plan

Create some jails.
Run:
jls
jls -N
jls -h
jls --libxo json,pretty
jls --libxo json,pretty -N
jls --libxo json,pretty -h

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• rodrigc updated this revision to Diff 10953.Dec 9 2015, 4:10 AM

• rodrigc retitled this revision from to Convert jls to use libxo.

• rodrigc updated this object.

• rodrigc edited the test plan for this revision. (Show Details)

• rodrigc added reviewers: allanjude, jamie, marcel, bapt.

• rodrigc added a subscriber: manu_bidouilliste.com.

Herald added a reviewer: manpages. · View Herald TranscriptDec 9 2015, 4:10 AM

Herald added a subscriber: imp. · View Herald Transcript

Remove stdout

Herald edited edge metadata. · View Herald TranscriptDec 9 2015, 4:13 AM

allanjude added inline comments.Dec 21 2015, 11:40 PM

usr.sbin/jls/jls.c
209 ↗	(On Diff #10954)	missing close }, bad padding, doesn't line up correctly
217 ↗	(On Diff #10954)	padding off by 1
391 ↗	(On Diff #10954)	instead of doing {e:hostname/%s}{d:hostname/%-29.29s} you can use the shorthand: {:hostname/%-29.29s/%s}
391 ↗	(On Diff #10954)	The path shouldn't get truncated
411 ↗	(On Diff #10954)	now the output is no longer padded to 15 characters. This is probably ok, but it does change the plain-text output (by removing space characters after the end of the line)
528 ↗	(On Diff #10954)	could the libxo 'quotes modifier' help here?