Page MenuHomeFreeBSD

Convert jls to use libxo
ClosedPublic

Authored by rodrigc on Dec 9 2015, 4:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 20, 6:44 PM
Unknown Object (File)
Fri, Jul 19, 12:27 PM
Unknown Object (File)
Wed, Jul 10, 5:28 AM
Unknown Object (File)
Sat, Jul 6, 12:13 PM
Unknown Object (File)
Sat, Jul 6, 12:11 PM
Unknown Object (File)
Wed, Jul 3, 5:09 AM
Unknown Object (File)
Mon, Jun 24, 4:01 AM
Unknown Object (File)
Jun 18 2024, 4:16 AM

Details

Summary

This was originally submitted under PR 200746.
I modified the patch slightly based on my
experience reviewing allanjude's conversion of procstat to libxo.

Test Plan

Create some jails.
Run:
jls
jls -N
jls -h
jls --libxo json,pretty
jls --libxo json,pretty -N
jls --libxo json,pretty -h

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1502
Build 1508: arc lint + arc unit

Event Timeline

rodrigc retitled this revision from to Convert jls to use libxo.
rodrigc updated this object.
rodrigc edited the test plan for this revision. (Show Details)
rodrigc added reviewers: allanjude, jamie, marcel, bapt.
rodrigc added a subscriber: manu_bidouilliste.com.
rodrigc edited edge metadata.

Remove stdout

usr.sbin/jls/jls.c
209

missing close }, bad padding, doesn't line up correctly

217

padding off by 1

391

instead of doing {e:hostname/%s}{d:hostname/%-29.29s} you can use the shorthand: {:hostname/%-29.29s/%s}

391

The path shouldn't get truncated

411

now the output is no longer padded to 15 characters. This is probably ok, but it does change the plain-text output (by removing space characters after the end of the line)

528

could the libxo 'quotes modifier' help here?

allanjude edited reviewers, added: rodrigc; removed: allanjude.
allanjude marked 4 inline comments as done.
allanjude edited edge metadata.

Fix some problems found during my review

This revision is now accepted and ready to land.Dec 22 2015, 12:31 AM
rodrigc edited reviewers, added: allanjude; removed: rodrigc.
This revision now requires review to proceed.Dec 22 2015, 12:34 AM
allanjude edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 12:36 AM
This revision was automatically updated to reflect the committed changes.