Page MenuHomeFreeBSD

Clarify how exports work for administrative controls
AbandonedPublic

Authored by rmacklem on Mar 25 2024, 7:45 PM.
Tags
None
Referenced Files
F105001899: D44499.diff
Wed, Dec 11, 1:00 PM
Unknown Object (File)
Mon, Nov 18, 8:10 AM
Unknown Object (File)
Oct 10 2024, 10:12 PM
Unknown Object (File)
Sep 29 2024, 11:59 AM
Unknown Object (File)
Sep 23 2024, 6:57 PM
Unknown Object (File)
Sep 23 2024, 2:31 PM
Unknown Object (File)
Sep 23 2024, 1:15 AM
Unknown Object (File)
Sep 22 2024, 8:01 PM
Subscribers

Details

Reviewers
markj
emaste
pauamma_gundo.com
gbe
Group Reviewers
manpages
Summary

There appears to be some confusion w.r.t. how exports
are applied to "administrative controls", which are exported
subdirectories within a server's local file system.

This patch attempts to clarify that the exports apply to the
entire server local file system and not the subtree below the
exported directory.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

makes sense to me. a couple of little notes on phrasing

usr.sbin/mountd/exports.5
626

this seems to imply the server has only one local file system, although I'm not sure what would be best

"any directory within a local file system on a server"
"any directory within any of a server's local file systems"

627

maybe "is exported, the entire file system is exported and not just the subtree..."
i.e. "those exports" doesn't seem to be needed

This revision is now accepted and ready to land.Mar 25 2024, 7:50 PM

Made the changes suggested by emaste@.

This revision now requires review to proceed.Mar 26 2024, 2:07 AM
This revision is now accepted and ready to land.Mar 26 2024, 2:22 AM
gbe added a subscriber: gbe.

LGTM

I'd somewhat prefer to make this more prominent, having its own paragraph in the description section. I understand that the problem at hand is a natural consequence of how exports(5) works, but it's really easy for someone new to NFS to miss that they can't "safely" export a single subdirectory from a local filesystem on the server.

I'd somewhat prefer to make this more prominent, having its own paragraph in the description section. I understand that the problem at hand is a natural consequence of how exports(5) works, but it's really easy for someone new to NFS to miss that they can't "safely" export a single subdirectory from a local filesystem on the server.

Go for it. I won't commit this one and will be happy to review
whatever you come up with.

I'd somewhat prefer to make this more prominent, having its own paragraph in the description section. I understand that the problem at hand is a natural consequence of how exports(5) works, but it's really easy for someone new to NFS to miss that they can't "safely" export a single subdirectory from a local filesystem on the server.

Go for it. I won't commit this one and will be happy to review
whatever you come up with.

I'm sorry for the delay. Here's my attempt: https://reviews.freebsd.org/D44614

markj@ has a better patch in D44614.