reboot: Implement -k in terms of env
ClosedPublic
Actions

Authored by imp on Feb 11 2024, 2:27 AM.

Details

Reviewers

kevans
kib
emaste

Commits

rG9dcf6cbd83fd: reboot: Implement -k in terms of env

Summary

kernel isn't special, beyond the sanity checks we do. Add it to the env
rather than pass it into write_nextboot().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55938
Build 52827: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 11 2024, 2:27 AM

imp created this revision.

Herald added a subscriber: cy. · View Herald TranscriptFeb 11 2024, 2:27 AM

Harbormaster completed remote builds in B55926: Diff 134127.Feb 11 2024, 2:27 AM

imp added a parent revision: D43827: reboot: Implement -e from nextboot.Feb 11 2024, 2:27 AM

imp added a child revision: D43829: reboot: Implement -o to set kernel options for next boot.

imp added reviewers: kevans, kib, emaste.Feb 11 2024, 2:31 AM

Review comments and code changes from refactoring env

Harbormaster completed remote builds in B55938: Diff 134148.Feb 11 2024, 5:06 PM

kib accepted this revision.Feb 12 2024, 2:11 AM

kib added inline comments.

sbin/reboot/reboot.c
119

This revision is now accepted and ready to land.Feb 12 2024, 2:11 AM

kevans accepted this revision.Feb 12 2024, 5:11 PM

Closed by commit rG9dcf6cbd83fd: reboot: Implement -k in terms of env (authored by imp). · Explain WhyFeb 12 2024, 6:54 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG9dcf6cbd83fd: reboot: Implement -k in terms of env.

Revision Contents
Changeset List

Path

Size

sbin/

reboot/

reboot.c

13 lines

Diff 134148

View Options

reboot: Implement -k in terms of envClosedPublicActions