Details

Reviewers

kib
kevans
emaste
markj

Commits

rG7cb1a0e6e064: reboot: Don't reboot if the next kernel isn't there

Summary

reboot -k garbage won't boot garbage unless /boot/garbage/kernel is
there. Refuse to reboot if it is missing, though allow -f to force
it for special-use cases.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 9 2024, 5:12 AM

imp created this revision.

Herald added a subscriber: cy. · View Herald TranscriptFeb 9 2024, 5:12 AM

Harbormaster completed remote builds in B55876: Diff 134030.Feb 9 2024, 5:12 AM

imp added a parent revision: D43801: reboot: convert flags to bools.Feb 9 2024, 5:12 AM

imp added reviewers: kib, kevans, emaste, markj.Feb 9 2024, 5:15 AM

kib added inline comments.Feb 9 2024, 6:30 AM

sbin/reboot/reboot.c
143	Wouldn't it better to use err() there, printing real errno?
150	If this open, or any of the following writes, failed, should we declare a similar failure? (if yes, this would be a separate change)

update per kib

Harbormaster completed remote builds in B55880: Diff 134041.Feb 9 2024, 4:24 PM

imp added a child revision: D43803: reboot: Add sanity checking of write to nextboot.conf.Feb 9 2024, 4:25 PM

imp marked 2 inline comments as done.Feb 9 2024, 4:35 PM

imp added inline comments.

sbin/reboot/reboot.c
143	Indeed. Good catch.
150	See D43803. Good suggestion, but the code got a little verbose... but not too bad and these days being as tiny as possible isn't a huge concern.

grahamperrin added a subscriber: grahamperrin.Feb 9 2024, 10:29 PM

kib added inline comments.Feb 10 2024, 12:01 AM

sbin/reboot/reboot.c
145	errno would already say 'no such item'. On the other hand, if error would be different like EIO, saying 'does not exist' before it is confusing. Typically we just emit the name of the failing syscall, "stat" in this case.