reboot: Implement -D from nextboot
ClosedPublic
Actions

Authored by imp on Feb 10 2024, 7:48 PM.

Details

Reviewers

emaste
kib
kevans
jhb

Commits

rG2c479548119a: reboot: Implement -D from nextboot

Summary

Implement -D from nextboot.sh which deletes the nextboot.conf file and
exists.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55961
Build 52850: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 10 2024, 7:48 PM

imp created this revision.

Herald added a subscriber: cy. · View Herald TranscriptFeb 10 2024, 7:48 PM

Harbormaster completed remote builds in B55913: Diff 134107.Feb 10 2024, 7:48 PM

imp added a child revision: D43823: zfsbootcfg: Remove bogus CFLAGS.Feb 10 2024, 7:48 PM

imp added reviewers: emaste, kib, kevans, jhb.Feb 10 2024, 7:49 PM

imp added a parent revision: D43803: reboot: Add sanity checking of write to nextboot.conf.Feb 10 2024, 7:55 PM

rebase / refresh / Add 'D' to getopt string

Harbormaster completed remote builds in B55922: Diff 134123.Feb 11 2024, 2:26 AM

kib added inline comments.Feb 11 2024, 7:14 AM

sbin/reboot/reboot.c
171	This op is not actual reboot. Do we care if the program is executed by set-uid caller?

imp marked an inline comment as done.Feb 12 2024, 6:21 PM

imp added inline comments.

sbin/reboot/reboot.c
171	Indeed. Updated to reflect.

move super user check

Harbormaster completed remote builds in B55961: Diff 134199.Feb 12 2024, 6:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2024, 6:54 PM

Closed by commit rG2c479548119a: reboot: Implement -D from nextboot (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2c479548119a: reboot: Implement -D from nextboot.

Revision Contents
Changeset List

Path

Size

sbin/

reboot/

reboot.8

12 lines

reboot.c

17 lines

Diff 134199

View Options

sbin/reboot/reboot.8