Page MenuHomeFreeBSD

arm64: fix db_read_bytes() for size == 8
ClosedPublic

Authored by mhorne on Jan 17 2024, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 2:55 PM
Unknown Object (File)
Jun 15 2024, 9:25 PM
Unknown Object (File)
May 20 2024, 5:05 PM
Unknown Object (File)
May 19 2024, 5:47 PM
Unknown Object (File)
May 16 2024, 7:53 PM
Unknown Object (File)
May 16 2024, 5:18 AM
Unknown Object (File)
May 12 2024, 5:01 AM
Unknown Object (File)
May 12 2024, 5:01 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

On a second look, the native-sized reads were not an optimization but rather to enable reading from device memory, per a67687fcd8f53.

So, just fix the cast.

mhorne edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 17 2024, 5:14 PM

Thanks fixing my bugs..

Seems like there ought to be a comment before the if size == 8 / else if / else if block.

jhb added inline comments.
sys/arm64/arm64/db_interface.c
134

I think const uint64_t * would be clearer here, and similarly for the other casts below.

This revision was automatically updated to reflect the committed changes.