busdma: emit a warning for use of filters

[mhorne]

Summary

Filter functions are deprecated, and unused in the tree. If either of
the filter or filterarg arguments to bus_dma_tag_create() are non-NULL,
print a warning.

This is a direct commit to stable/14.

[emaste]

sys/arm/arm/busdma_machdep.c

403

maybe "use of busdma filters"?

Although perhaps the man page reference is enough of a clue

[jhb]

It's a shame we can't print out the name of the offending device. Probably want this in stable/13 as well.

[emaste]

It's a shame we can't print out the name of the offending device.

Indeed - I'm not particularly familiar with this interface but went looking to see if there was a reasonable way to give more information. We could perhaps print a backtrace? In practice though if a user sees this message asking for a (perhaps verbose) dmesg should be sufficient, I'd think.

sys/arm/arm/busdma_machdep.c

  * - setup various driver entry points
  * - invoke the vmbus hv main init routine
  * - get the irq resource
  * - invoke the vmbus to add the vmbus root device
  * - setup the vmbus root device
  * - retrieve the channel offers
  */
 static int
-vmbus_bus_init(void)
+vmbus_doattach(struct vmbus_softc *sc)
 {
-        struct vmbus_softc *sc = vmbus_get_softc();
         int ret;
 
         if (sc->vmbus_flags & VMBUS_FLAG_ATTACHED)
                 return (0);
         sc->vmbus_flags |= VMBUS_FLAG_ATTACHED;
 
         /*
          * Create context for "post message" Hypercalls
#ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible indicated by the global
          * cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold)
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(vmbus_sc);
 
         bus_generic_probe(dev);
         return (0);
 }
 
 static void
 vmbus_sysinit(void *arg __unused)
 {
-        if (vm_guest != VM_GUEST_HV || vmbus_get_softc() == NULL)
+        struct vmbus_softc *sc = vmbus_get_softc();
+
+        if (vm_guest != VM_GUEST_HV || sc == NULL)
                 return;
 
 #ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible, as indicated by the
          * global cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold) 
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(sc);
 }
 
 static int
 vmbus_detach(device_t dev)
 {
         struct vmbus_softc *sc = device_get_softc(dev);
 
         hv_vmbus_release_unattached_channels();

sys/arm64/arm64/busdma_machdep.c

  * - setup various driver entry points
  * - invoke the vmbus hv main init routine
  * - get the irq resource
  * - invoke the vmbus to add the vmbus root device
  * - setup the vmbus root device
  * - retrieve the channel offers
  */
 static int
-vmbus_bus_init(void)
+vmbus_doattach(struct vmbus_softc *sc)
 {
-        struct vmbus_softc *sc = vmbus_get_softc();
         int ret;
 
         if (sc->vmbus_flags & VMBUS_FLAG_ATTACHED)
                 return (0);
         sc->vmbus_flags |= VMBUS_FLAG_ATTACHED;
 
         /*
          * Create context for "post message" Hypercalls
#ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible indicated by the global
          * cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold)
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(vmbus_sc);
 
         bus_generic_probe(dev);
         return (0);
 }
 
 static void
 vmbus_sysinit(void *arg __unused)
 {
-        if (vm_guest != VM_GUEST_HV || vmbus_get_softc() == NULL)
+        struct vmbus_softc *sc = vmbus_get_softc();
+
+        if (vm_guest != VM_GUEST_HV || sc == NULL)
                 return;
 
 #ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible, as indicated by the
          * global cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold) 
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(sc);
 }
 
 static int
 vmbus_detach(device_t dev)
 {
         struct vmbus_softc *sc = device_get_softc(dev);
 
         hv_vmbus_release_unattached_channels();

sys/powerpc/powerpc/busdma_machdep.c

  * - setup various driver entry points
  * - invoke the vmbus hv main init routine
  * - get the irq resource
  * - invoke the vmbus to add the vmbus root device
  * - setup the vmbus root device
  * - retrieve the channel offers
  */
 static int
-vmbus_bus_init(void)
+vmbus_doattach(struct vmbus_softc *sc)
 {
-        struct vmbus_softc *sc = vmbus_get_softc();
         int ret;
 
         if (sc->vmbus_flags & VMBUS_FLAG_ATTACHED)
                 return (0);
         sc->vmbus_flags |= VMBUS_FLAG_ATTACHED;
 
         /*
          * Create context for "post message" Hypercalls
#ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible indicated by the global
          * cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold)
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(vmbus_sc);
 
         bus_generic_probe(dev);
         return (0);
 }
 
 static void
 vmbus_sysinit(void *arg __unused)
 {
-        if (vm_guest != VM_GUEST_HV || vmbus_get_softc() == NULL)
+        struct vmbus_softc *sc = vmbus_get_softc();
+
+        if (vm_guest != VM_GUEST_HV || sc == NULL)
                 return;
 
 #ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible, as indicated by the
          * global cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold) 
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(sc);
 }
 
 static int
 vmbus_detach(device_t dev)
 {
         struct vmbus_softc *sc = device_get_softc(dev);
 
         hv_vmbus_release_unattached_channels();

sys/riscv/riscv/busdma_machdep.c

  * - setup various driver entry points
  * - invoke the vmbus hv main init routine
  * - get the irq resource
  * - invoke the vmbus to add the vmbus root device
  * - setup the vmbus root device
  * - retrieve the channel offers
  */
 static int
-vmbus_bus_init(void)
+vmbus_doattach(struct vmbus_softc *sc)
 {
-        struct vmbus_softc *sc = vmbus_get_softc();
         int ret;
 
         if (sc->vmbus_flags & VMBUS_FLAG_ATTACHED)
                 return (0);
         sc->vmbus_flags |= VMBUS_FLAG_ATTACHED;
 
         /*
          * Create context for "post message" Hypercalls
#ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible indicated by the global
          * cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold)
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(vmbus_sc);
 
         bus_generic_probe(dev);
         return (0);
 }
 
 static void
 vmbus_sysinit(void *arg __unused)
 {
-        if (vm_guest != VM_GUEST_HV || vmbus_get_softc() == NULL)
+        struct vmbus_softc *sc = vmbus_get_softc();
+
+        if (vm_guest != VM_GUEST_HV || sc == NULL)
                 return;
 
 #ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible, as indicated by the
          * global cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold) 
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(sc);
 }
 
 static int
 vmbus_detach(device_t dev)
 {
         struct vmbus_softc *sc = device_get_softc(dev);
 
         hv_vmbus_release_unattached_channels();

sys/x86/x86/busdma_machdep.c

  * - setup various driver entry points
  * - invoke the vmbus hv main init routine
  * - get the irq resource
  * - invoke the vmbus to add the vmbus root device
  * - setup the vmbus root device
  * - retrieve the channel offers
  */
 static int
-vmbus_bus_init(void)
+vmbus_doattach(struct vmbus_softc *sc)
 {
-        struct vmbus_softc *sc = vmbus_get_softc();
         int ret;
 
         if (sc->vmbus_flags & VMBUS_FLAG_ATTACHED)
                 return (0);
         sc->vmbus_flags |= VMBUS_FLAG_ATTACHED;
 
         /*
          * Create context for "post message" Hypercalls
#ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible indicated by the global
          * cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold)
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(vmbus_sc);
 
         bus_generic_probe(dev);
         return (0);
 }
 
 static void
 vmbus_sysinit(void *arg __unused)
 {
-        if (vm_guest != VM_GUEST_HV || vmbus_get_softc() == NULL)
+        struct vmbus_softc *sc = vmbus_get_softc();
+
+        if (vm_guest != VM_GUEST_HV || sc == NULL)
                 return;
 
 #ifndef EARLY_AP_STARTUP
         /* 
          * If the system has already booted and thread
          * scheduling is possible, as indicated by the
          * global cold set to zero, we just call the driver
          * initialization directly.
          */
         if (!cold) 
 #endif
-                vmbus_bus_init();
+                vmbus_doattach(sc);
 }
 
 static int
 vmbus_detach(device_t dev)
 {
         struct vmbus_softc *sc = device_get_softc(dev);
 
         hv_vmbus_release_unattached_channels();