Page MenuHomeFreeBSD

busdma: emit a warning for use of filters
ClosedPublic

Authored by mhorne on Dec 4 2023, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 3:27 AM
Unknown Object (File)
Wed, Nov 26, 9:54 PM
Unknown Object (File)
Thu, Nov 13, 7:18 PM
Unknown Object (File)
Thu, Nov 13, 1:31 AM
Unknown Object (File)
Thu, Nov 13, 12:36 AM
Unknown Object (File)
Wed, Nov 12, 1:04 AM
Unknown Object (File)
Nov 6 2025, 9:00 AM
Unknown Object (File)
Nov 4 2025, 4:44 AM
Subscribers

Details

Summary

Filter functions are deprecated, and unused in the tree. If either of
the filter or filterarg arguments to bus_dma_tag_create() are non-NULL,
print a warning.

This is a direct commit to stable/14.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Dec 4 2023, 3:49 PM
emaste added inline comments.
sys/arm/arm/busdma_machdep.c
403

maybe "use of busdma filters"?

Although perhaps the man page reference is enough of a clue

This revision is now accepted and ready to land.Dec 4 2023, 6:01 PM

It's a shame we can't print out the name of the offending device. Probably want this in stable/13 as well.

It's a shame we can't print out the name of the offending device.

Indeed - I'm not particularly familiar with this interface but went looking to see if there was a reasonable way to give more information. We could perhaps print a backtrace? In practice though if a user sees this message asking for a (perhaps verbose) dmesg should be sufficient, I'd think.

This revision was automatically updated to reflect the committed changes.