mpi3mr: Replace can't happen DataLength == 0 with an assert
ClosedPublic
Actions

Authored by imp on Nov 28 2023, 9:06 PM.

Details

Reviewers

jhb
chs
mav
sumit.saxena_broadcom.com
chandrakanth.patil_broadcom.com

Commits

rGac7d9eaf066b: mpi3mr: Replace can't happen DataLength == 0 with an assert
rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert

Summary

Replace the test for DataLength == 0 with an assert. It can't happen,
but an assert doesn't hurt. Emacs removed some trailing white space too.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54663
Build 51552: arc lint + arc unit

Event Timeline

imp requested review of this revision.Nov 28 2023, 9:06 PM

imp created this revision.

Harbormaster completed remote builds in B54663: Diff 130692.Nov 28 2023, 9:06 PM

imp added a child revision: D42808: mpi3mr: Assume dma_hiaddr is BUS_SPACE_MAXADDR.Nov 28 2023, 9:06 PM

imp added reviewers: jhb, chs, mav, sumit.saxena_broadcom.com, chandrakanth.patil_broadcom.com.Nov 28 2023, 9:06 PM

imp added a parent revision: D42607: mpi3mr: Use template for main busdma tag..

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2023, 1:56 AM

Closed by commit rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert.

mav added a commit: rGac7d9eaf066b: mpi3mr: Replace can't happen DataLength == 0 with an assert.Jan 19 2024, 5:18 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mpi3mr/

mpi3mr_cam.c

18 lines

Diff 130692

View Options

sys/dev/mpi3mr/mpi3mr_cam.c

mpi3mr: Replace can't happen DataLength == 0 with an assertClosedPublicActions