Page MenuHomeFreeBSD
Differential D42588

mpi3mr: Add firmware version
ClosedPublic
Actions

Authored by imp on Nov 13 2023, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 3:15 PM
Unknown Object (File)
Wed, Oct 29, 12:02 PM
Unknown Object (File)
Wed, Oct 29, 5:17 AM
Unknown Object (File)
Wed, Oct 29, 5:07 AM
Unknown Object (File)
Wed, Oct 29, 3:38 AM
Unknown Object (File)
Sun, Oct 26, 5:39 AM
Unknown Object (File)
Sat, Oct 25, 2:56 PM
Unknown Object (File)
Tue, Oct 21, 11:53 AM
View All 73 Files
Subscribers
None

Details

Reviewers
chs
sumit.saxena_broadcom.com
chandrakanth.patil_broadcom.com
jhb
mav
Commits
rG835db4182391: mpi3mr: Add firmware version
rG28a274342ea0: mpi3mr: Add firmware version
Summary

Publish the firmware version on the card like we do for mps/mpr.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Nov 13 2023, 10:53 PM
imp created this revision.
Harbormaster completed remote builds in B54412: Diff 130061.Nov 13 2023, 10:53 PM
imp added reviewers: chs, sumit.saxena_broadcom.com, chandrakanth.patil_broadcom.com.Nov 13 2023, 10:53 PM
imp mentioned this in D42604: mpi3mr: Fix major DMA handling bugs.Nov 14 2023, 9:37 PM
imp added a parent revision: D42559: mpi3mr: Honor the dma mask from IOCFacts.Nov 14 2023, 10:21 PM
imp added reviewers: jhb, mav.
imp added a child revision: D42605: mpi3mr: Fix MAXPHYS usage.
mav accepted this revision.Nov 15 2023, 12:23 AM
mav added inline comments.
sys/dev/mpi3mr/mpi3mr.c
2248

I wonder if it really belong in this display function or should be somewhere higher/else?

This revision is now accepted and ready to land.Nov 15 2023, 12:23 AM
imp added inline comments.Nov 15 2023, 3:09 AM
sys/dev/mpi3mr/mpi3mr.c
2248

Yea, I'm not entirely sure either. It was a convenient place to add it since this is called only once...
Should I change it?

mav added inline comments.Nov 15 2023, 2:56 PM
sys/dev/mpi3mr/mpi3mr.c
2248

Meh, but you could at least reduce code duplication by just printing the produced string above.

imp updated this revision to Diff 130162.Nov 15 2023, 9:22 PM

Go ahead and move fw version formatting... In hindsight, no sense being grumpy
about it.

This revision now requires review to proceed.Nov 15 2023, 9:22 PM
Harbormaster completed remote builds in B54464: Diff 130162.Nov 15 2023, 9:22 PM
mav accepted this revision.Nov 15 2023, 9:44 PM

Was I looking grumpy? I didn't mean to, sorry if so.

This revision is now accepted and ready to land.Nov 15 2023, 9:44 PM
imp added a comment.EditedNov 15 2023, 10:12 PM
In D42588#972491, @mav wrote:

Was I looking grumpy? I didn't mean to, sorry if so.

No. I was grumpy at your suggestion which was good. I'm sorry about that.

Closed by commit rG28a274342ea0: mpi3mr: Add firmware version (authored by imp). · Explain WhyNov 29 2023, 1:56 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG28a274342ea0: mpi3mr: Add firmware version.
mav added a commit: rG835db4182391: mpi3mr: Add firmware version.Jan 19 2024, 5:18 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mpi3mr/
3 lines
15 lines
4 lines

Diff 130728

View Options

sys/dev/mpi3mr/mpi3mr.h

Loading...
View Options

sys/dev/mpi3mr/mpi3mr.c

Loading...
View Options

sys/dev/mpi3mr/mpi3mr_pci.c

Loading...