mpi3mr: Remove unused fields in struct mpi3mr_cmd
ClosedPublic
Actions

Authored by imp on Nov 10 2023, 12:19 AM.

Details

Reviewers

jhb
chs
sumit.saxena_broadcom.com
chandrakanth.patil_broadcom.com
mav

Commits

rGe82c6e941e6a: mpi3mr: Remove unused fields in struct mpi3mr_cmd
rGa2b046620c54: mpi3mr: Remove unused fields in struct mpi3mr_cmd

Summary

All of these fields are either unused, or just initialized. Remove
them. This saves about 1MB of memory for the cards that I have which can
do 8k transactions at once.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Nov 10 2023, 12:19 AM

imp created this revision.

Harbormaster completed remote builds in B54361: Diff 129915.Nov 10 2023, 12:19 AM

imp added a parent revision: D42537: mpi3mr: Don't hold fwevt_lock over call to taskqueue_drain.Nov 10 2023, 12:19 AM

imp added a child revision: D42539: mpi3mr: Reduce the scope of the reset_mutext.

imp mentioned this in D42604: mpi3mr: Fix major DMA handling bugs.Nov 14 2023, 9:37 PM

imp added a reviewer: mav.Nov 14 2023, 10:19 PM

I have no clue where are they are coming from, it if not needed -- sure, axe them out.

This revision is now accepted and ready to land.Nov 14 2023, 11:46 PM

jhb accepted this revision.Nov 28 2023, 4:55 PM

Closed by commit rGa2b046620c54: mpi3mr: Remove unused fields in struct mpi3mr_cmd (authored by imp). · Explain WhyNov 29 2023, 1:55 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa2b046620c54: mpi3mr: Remove unused fields in struct mpi3mr_cmd.

mav added a commit: rGe82c6e941e6a: mpi3mr: Remove unused fields in struct mpi3mr_cmd.Jan 19 2024, 5:17 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mpi3mr/

mpi3mr.h

6 lines

mpi3mr.c

3 lines

Diff 130721

View Options

sys/dev/mpi3mr/mpi3mr.h