Differential D42807

mpi3mr: Replace can't happen DataLength == 0 with an assert
ClosedPublic
Actions

Authored by imp on Nov 28 2023, 9:06 PM.

Tags

None

Referenced Files

	F175030862: D42807.diff
	Wed, Oct 7, 6:36 PM

	F175015389: D42807.id130732.diff
	Wed, Oct 7, 3:50 PM

	Unknown Object (File)
	Fri, Oct 2, 2:21 PM

	Unknown Object (File)
	Sun, Sep 20, 10:27 PM

	Unknown Object (File)
	Aug 24 2026, 1:51 AM

	Unknown Object (File)
	Aug 20 2026, 1:19 PM

	Unknown Object (File)
	Aug 15 2026, 9:30 AM

	Unknown Object (File)
	Aug 15 2026, 12:26 AM

Subscribers

None

Details

Reviewers

jhb
chs
mav
sumit.saxena_broadcom.com
chandrakanth.patil_broadcom.com

Commits

rGac7d9eaf066b: mpi3mr: Replace can't happen DataLength == 0 with an assert
rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert

Summary

Replace the test for DataLength == 0 with an assert. It can't happen,
but an assert doesn't hurt. Emacs removed some trailing white space too.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Nov 28 2023, 9:06 PM

imp created this revision.

Harbormaster completed remote builds in B54663: Diff 130692.Nov 28 2023, 9:06 PM

imp added a child revision: D42808: mpi3mr: Assume dma_hiaddr is BUS_SPACE_MAXADDR.Nov 28 2023, 9:06 PM

imp added reviewers: jhb, chs, mav, sumit.saxena_broadcom.com, chandrakanth.patil_broadcom.com.Nov 28 2023, 9:06 PM

imp added a parent revision: D42607: mpi3mr: Use template for main busdma tag..

This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2023, 1:56 AM

Closed by commit rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2361a0056fc1: mpi3mr: Replace can't happen DataLength == 0 with an assert.

mav added a commit: rGac7d9eaf066b: mpi3mr: Replace can't happen DataLength == 0 with an assert.Jan 19 2024, 5:18 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mpi3mr/

18 lines

Diff 130732

sys/dev/mpi3mr/mpi3mr_cam.c

Loading...