Differential D4277

Casper new architecture.
ClosedPublic
Actions

Authored by oshogbo on Nov 25 2015, 9:20 PM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 5:13 PM

	Unknown Object (File)
	Thu, Dec 19, 4:56 PM

	Unknown Object (File)
	Thu, Dec 19, 4:52 PM

	Unknown Object (File)
	Thu, Dec 19, 2:02 PM

	Unknown Object (File)
	Sun, Dec 8, 9:41 PM

	Unknown Object (File)
	Tue, Dec 3, 12:40 PM

	Unknown Object (File)
	Sat, Nov 30, 9:47 AM

	Unknown Object (File)
	Fri, Nov 29, 7:11 AM

Subscribers

drysdale_google.com

Details

Reviewers

ed
jonathan
bdrewery

Commits

rS296047: Convert casperd(8) daemon to the libcasper.

Summary

Threads:
https://lists.freebsd.org/pipermail/freebsd-arch/2015-November/017519.html
https://lists.cam.ac.uk/pipermail/cl-capsicum-discuss/2015-November/msg00004.html

Code is also available at:
https://github.com/oshogbo/freebsd/tree/libcasper

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo updated this revision to Diff 10503.Nov 25 2015, 9:20 PM

oshogbo retitled this revision from to Casper new architecture..

oshogbo updated this object.

oshogbo edited the test plan for this revision. (Show Details)

oshogbo added a reviewer: jonathan.

oshogbo added a project: capsicum.

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptNov 25 2015, 9:20 PM

drysdale_google.com added a subscriber: drysdale_google.com.Dec 8 2015, 4:01 PM

I *think* that nvlist_add_string() and friends don't cope with a NULL value, which means that all of the places where optional strings turn up in an API need to cope with absence. I've commented on a few such places, but there's probably more...

lib/libcasper/services/cap_dns/cap_dns.c
199	Should this be prefixed with a if (nvlist_exists_string(nvl, "ai_canonname")), plus an initialization of canonname to NULL above?
229–230	Either one of hostname/servname can be NULL, which I don't think nvlist_add_string() copes with.
300	add && nvlist_exists_string(nvl, "host") ?
302	add && nvlist_exists_string(nvl, "serv") ?
518	Need to initialize both of these to NULL I think
578	check that host/serv are != NULL ?
598	Check for ai->ai_canonname == NULL?
617	Can hostname/servname be absent?
tools/regression/capsicum/libcasper/dns.c
50	Presumably these tests haven't been updated yet?

Update according to David suggestion.
I forgot to commit changes about test, thanks!
You make very good points.

oshogbo marked 9 inline comments as done.Dec 14 2015, 12:10 AM

oshogbo added inline comments.

lib/libcasper/services/cap_dns/cap_dns.c
199	dnvlist will be bather here but you are right we should check this value.
518	It's done. Just before memset.

Code is also available at https://github.com/oshogbo/freebsd/tree/libcasper

oshogbo updated this object.Jan 8 2016, 3:37 PM

oshogbo added a reviewer: ed.

oshogbo added subscribers: rwatson, pjd.

Please also update these as needed:

targets/pseudo/userland/Makefile.depend:DIRDEPS+= sbin/casperd
targets/pseudo/userland/lib/Makefile.depend: lib/libcasper \
targets/pseudo/userland/libexec/Makefile.depend: libexec/casper/dns \
targets/pseudo/userland/libexec/Makefile.depend: libexec/casper/grp \
targets/pseudo/userland/libexec/Makefile.depend: libexec/casper/pwd \
targets/pseudo/userland/libexec/Makefile.depend: libexec/casper/random \
targets/pseudo/userland/libexec/Makefile.depend: libexec/casper/sysctl \

Makefile.inc1
551	This change should not be needed. The change in etc/mtree/BSD.root.dist will create the directory.

This revision now requires changes to proceed.Jan 8 2016, 6:55 PM

I updated Makefile.depnd which was pointed out byt @bdrewery.
I update also some dependencies in libnames and BSD.debug.dist.

Closed by commit rS296047: Convert casperd(8) daemon to the libcasper. (authored by oshogbo). · Explain WhyFeb 26 2016, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

8 lines

ObsoleteFiles.inc

19 lines

contrib/

mdocml/

2 lines

tcpdump/

14 lines

2 lines

2 lines

2 lines

63 lines

etc/

defaults/

1 line

mtree/

BSD.include.dist

2 lines

4 lines

rc.d/

5 lines

lib/

5 lines

libc/

posix1e/

4 lines

libcapsicum/

Makefile.depend

libcapsicum_dns.h

libcapsicum_dns.c

libcapsicum_grp.h

libcapsicum_grp.c

libcapsicum_impl.h

libcapsicum_pwd.h

libcapsicum_pwd.c

libcapsicum_random.h

libcapsicum_random.c

libcapsicum_service.h

libcapsicum_service.c

libcapsicum_sysctl.h

libcapsicum_sysctl.c

libcasper/

19 lines

libcasper/

38 lines

115 lines

295 lines

337 lines

libcasper_impl.h

82 lines

libcasper_impl.c

44 lines

libcasper_service.h

60 lines

libcasper_service.c

277 lines

394 lines

41 lines

223 lines

libcasper_impl.h

services/

9 lines

cap_dns/

20 lines

57 lines

761 lines

cap_grp/

20 lines

57 lines

787 lines

cap_pwd/

20 lines

57 lines

783 lines

cap_random/

20 lines

37 lines

117 lines

cap_sysctl/

20 lines

43 lines

293 lines

libexec/

5 lines

casper/

dns/

grp/

pwd/

random/

sysctl/

rtld-elf/

2 lines

sbin/

1 line

casperd/

ping/

5 lines

Makefile.depend

3 lines

34 lines

share/

man/

man4/

5 lines

mk/

bsd.libnames.mk

1 line

src.libnames.mk

17 lines

tools/

regression/

capsicum/

libcapsicum/

libcasper/

32 lines

588 lines

1550 lines

1536 lines

1510 lines

usr.bin/

kdump/

6 lines

31 lines

usr.sbin/

tcpdump/

tcpdump/

5 lines

2 lines

Diff 11216

Makefile.inc1

Loading...

ObsoleteFiles.inc

Loading...

contrib/mdocml/lib.in

Loading...

contrib/tcpdump/addrtoname.c

Loading...

contrib/tcpdump/config.h.in

Loading...

contrib/tcpdump/configure

Loading...

contrib/tcpdump/configure.in

Loading...

contrib/tcpdump/tcpdump.c

Loading...

etc/defaults/rc.conf

Loading...

etc/mtree/BSD.include.dist

Loading...

etc/mtree/BSD.root.dist

Loading...

etc/rc.d/Makefile

Loading...

etc/rc.d/casperd

Loading...

lib/Makefile

Loading...

lib/libc/posix1e/posix1e.3

Loading...

lib/libcapsicum/Makefile

Loading...

lib/libcapsicum/Makefile.depend

Loading...

lib/libcapsicum/libcapsicum.h

Loading...

lib/libcapsicum/libcapsicum.3

Loading...

lib/libcapsicum/libcapsicum.c

Loading...

lib/libcapsicum/libcapsicum_dns.h

Loading...

lib/libcapsicum/libcapsicum_dns.c

Loading...

lib/libcapsicum/libcapsicum_grp.h

Loading...

lib/libcapsicum/libcapsicum_grp.c

Loading...

lib/libcapsicum/libcapsicum_impl.h

Loading...

lib/libcapsicum/libcapsicum_pwd.h

Loading...

lib/libcapsicum/libcapsicum_pwd.c

Loading...

lib/libcapsicum/libcapsicum_random.h

Loading...

lib/libcapsicum/libcapsicum_random.c

Loading...

lib/libcapsicum/libcapsicum_service.h

Loading...

lib/libcapsicum/libcapsicum_service.c

Loading...

lib/libcapsicum/libcapsicum_sysctl.h

Loading...

lib/libcapsicum/libcapsicum_sysctl.c

Loading...

lib/libcasper/Makefile

Loading...

lib/libcasper/libcasper.h

Loading...

lib/libcasper/libcasper.c

Loading...

lib/libcasper/libcasper/Makefile

Loading...

lib/libcasper/libcasper/libcasper.h

Loading...

lib/libcasper/libcasper/libcasper.3

Loading...

lib/libcasper/libcasper/libcasper.c

Loading...

lib/libcasper/libcasper/libcasper_impl.h

Loading...

lib/libcasper/libcasper/libcasper_impl.c

Loading...

lib/libcasper/libcasper/libcasper_service.h

Loading...

lib/libcasper/libcasper/libcasper_service.c

Loading...

lib/libcasper/libcasper/service.c

Loading...

lib/libcasper/libcasper/zygote.h

Loading...

lib/libcasper/libcasper/zygote.c

Loading...

lib/libcasper/libcasper_impl.h

Loading...

lib/libcasper/services/Makefile

Loading...

lib/libcasper/services/cap_dns/Makefile

Loading...

lib/libcasper/services/cap_dns/cap_dns.h

Loading...

lib/libcasper/services/cap_dns/cap_dns.c

Loading...

lib/libcasper/services/cap_grp/Makefile

Loading...

lib/libcasper/services/cap_grp/cap_grp.h

Loading...

lib/libcasper/services/cap_grp/cap_grp.c

Loading...

lib/libcasper/services/cap_pwd/Makefile

Loading...

lib/libcasper/services/cap_pwd/cap_pwd.h

Loading...

lib/libcasper/services/cap_pwd/cap_pwd.c

Loading...

lib/libcasper/services/cap_random/Makefile

Loading...

lib/libcasper/services/cap_random/cap_random.h

Loading...

lib/libcasper/services/cap_random/cap_random.c

Loading...

lib/libcasper/services/cap_sysctl/Makefile

Loading...

lib/libcasper/services/cap_sysctl/cap_sysctl.h

Loading...

lib/libcasper/services/cap_sysctl/cap_sysctl.c

Loading...

libexec/Makefile

Loading...

libexec/casper/Makefile

Loading...

libexec/casper/dns/Makefile

Loading...

libexec/casper/dns/dns.c

Loading...

libexec/casper/grp/Makefile

Loading...

libexec/casper/grp/grp.c

Loading...

libexec/casper/pwd/Makefile

Loading...

libexec/casper/pwd/pwd.c

Loading...

libexec/casper/random/Makefile

Loading...

libexec/casper/random/random.c

Loading...

libexec/casper/sysctl/Makefile

Loading...

libexec/casper/sysctl/sysctl.c

Loading...

libexec/rtld-elf/paths.h

Loading...

sbin/Makefile

Loading...

sbin/casperd/Makefile

Loading...

sbin/casperd/casperd.8

Loading...

sbin/casperd/casperd.c

Loading...

sbin/casperd/zygote.h

Loading...

sbin/casperd/zygote.c

Loading...

sbin/ping/Makefile

Loading...

sbin/ping/Makefile.depend

Loading...

sbin/ping/ping.c

Loading...

share/man/man4/capsicum.4

Loading...

share/mk/bsd.libnames.mk

Loading...

share/mk/src.libnames.mk

Loading...

tools/regression/capsicum/libcapsicum/Makefile

Loading...

tools/regression/capsicum/libcapsicum/dns.c

Loading...

tools/regression/capsicum/libcapsicum/grp.c

Loading...

tools/regression/capsicum/libcapsicum/pwd.c

Loading...

tools/regression/capsicum/libcapsicum/sysctl.c

Loading...

tools/regression/capsicum/libcasper/Makefile

Loading...

tools/regression/capsicum/libcasper/dns.c

Loading...

tools/regression/capsicum/libcasper/grp.c

Loading...

tools/regression/capsicum/libcasper/pwd.c

Loading...

tools/regression/capsicum/libcasper/sysctl.c

Loading...

usr.bin/kdump/Makefile

Loading...

usr.bin/kdump/kdump.c

Loading...

usr.sbin/tcpdump/tcpdump/Makefile

Loading...

usr.sbin/tcpdump/tcpdump/config.h

Loading...