When the macro PACKAGE_BUILDING is set, then consider we are building package for pkgbase, this has already been used in Makefile.inc1 and reuse the PACKAGE_BUILDING macros already used for that purpose in the ports tree
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This should be set in general for reproducible builds, to be honest, of which pkgbase is but one user.
Comment Actions
I agree with @jrtc27 that tying it to reproducible builds is sensible -- I'm fine with either change.
I'd like to understand the full workflow with gdb and lldb better.
Comment Actions
It turns out that when poudriere jail is run with -b, the PACKAGE_BUILDING isn't defined: https://github.com/freebsd/poudriere/issues/1196
On the other hand, why wrap these CFLAGS into .if (PACKAGE_BUILDING) at all? It feels to me that these flags are correct for any case.
Comment Actions
this is not for all case because people may have multiple checkouts of the source tree (other than /usr/src) this is good only for releases.