alq, siftr: add panic/debugger checks to shutdown hooks
ClosedPublic
Actions

Authored by mhorne on Oct 23 2023, 8:32 PM.

Details

Reviewers

markj
jhb

Commits

rGbbfd41d4308b: alq, siftr: add panic/debugger checks to shutdown hooks
rGd79a9edb5ce1: alq, siftr: add panic/debugger checks to shutdown hooks

Summary

Don't try to gracefully terminate the pkt_manager thread if the
scheduler is not running.

We should not attempt to shutdown ald if RB_NOSYNC is set, and must not
if the scheduler is stopped (the function calls wakeup()).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Oct 23 2023, 8:32 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptOct 23 2023, 8:32 PM

mhorne requested review of this revision.Oct 23 2023, 8:32 PM

Harbormaster completed remote builds in B54141: Diff 129262.Oct 23 2023, 8:32 PM

mhorne added a parent revision: D42339: powerpc: better handling of shutdown flags.Oct 23 2023, 8:32 PM

mhorne added a child revision: D42341: ctl_ha: don't shutdown threads if scheduler is stopped.

Yes I don't think these handlers will work properly in panic context.

We should not attempt to shutdown ald if RB_NOSYNC is set

ald -> alq

This revision is now accepted and ready to land.Nov 2 2023, 3:27 PM

Closed by commit rGd79a9edb5ce1: alq, siftr: add panic/debugger checks to shutdown hooks (authored by mhorne). · Explain WhyNov 23 2023, 4:08 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGd79a9edb5ce1: alq, siftr: add panic/debugger checks to shutdown hooks.

mhorne added a commit: rGbbfd41d4308b: alq, siftr: add panic/debugger checks to shutdown hooks.Dec 8 2023, 10:03 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_alq.c

14 lines

netinet/

siftr.c

6 lines

Diff 130467

View Options

sys/kern/kern_alq.c