iscsi: adjust shutdown_pre_sync handler
ClosedPublic
Actions

Authored by mhorne on Oct 23 2023, 8:33 PM.

Details

Reviewers

markj
jhb

Commits

rGa8ba64ca91d4: iscsi: adjust shutdown_pre_sync handler
rG2ce1c45b3411: iscsi: adjust shutdown_pre_sync handler

Summary

Don't attempt to service reconnections if RB_NOSYNC is set (somewhat
debatable). More crucially, don't do it if the scheduler is stopped,
as the maintenance thread will never run again.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Oct 23 2023, 8:33 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2023, 8:33 PM

mhorne requested review of this revision.Oct 23 2023, 8:33 PM

Harbormaster completed remote builds in B54143: Diff 129264.Oct 23 2023, 8:33 PM

mhorne added a parent revision: D42341: ctl_ha: don't shutdown threads if scheduler is stopped.Oct 23 2023, 8:33 PM

mhorne added a child revision: D42343: xen: improve shutdown hook.

I think skipping this for RB_NOSYNC is sensible.

This revision is now accepted and ready to land.Nov 17 2023, 12:39 AM

Closed by commit rG2ce1c45b3411: iscsi: adjust shutdown_pre_sync handler (authored by mhorne). · Explain WhyNov 23 2023, 4:08 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG2ce1c45b3411: iscsi: adjust shutdown_pre_sync handler.

mhorne added a commit: rGa8ba64ca91d4: iscsi: adjust shutdown_pre_sync handler.Dec 8 2023, 10:03 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

iscsi/

iscsi.c

6 lines

Diff 130469

View Options

iscsi: adjust shutdown_pre_sync handlerClosedPublicActions