Page MenuHomeFreeBSD

bsdinstall: Fail nicely in jail target
ClosedPublic

Authored by fernape on Oct 17 2023, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 11:55 AM
Unknown Object (File)
Fri, Jan 24, 8:50 PM
Unknown Object (File)
Tue, Jan 21, 8:40 AM
Unknown Object (File)
Jan 10 2025, 5:09 AM
Unknown Object (File)
Jan 10 2025, 5:00 AM
Unknown Object (File)
Dec 2 2024, 12:39 PM
Unknown Object (File)
Dec 2 2024, 12:39 PM
Unknown Object (File)
Dec 2 2024, 12:39 PM
Subscribers

Details

Summary

If the directory is empty, then we fail with a message regarding mkdir in
which the empty directory can't be seen because it is not quoted.

Show a nice message so the user knows what is going on.

Test Plan

Apply patch and execute:
bsdinstall jail

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt added a subscriber: bapt.

small style remark, please address before pushing, other that that, lookgs good to me

usr.sbin/bsdinstall/scripts/jail
56

to be consistent with the rest of the code in this script please remove the { and }

This revision is now accepted and ready to land.Oct 18 2023, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Done with the suggested change.

Thanks for the review!