Page MenuHomeFreeBSD

bsdinstall: Fail nicely in jail target
ClosedPublic

Authored by fernape on Oct 17 2023, 1:39 PM.
Tags
None
Referenced Files
F159448030: D42252.id128910.diff
Sun, Jun 14, 6:27 AM
Unknown Object (File)
Tue, Jun 9, 7:28 PM
Unknown Object (File)
Tue, Jun 9, 4:50 PM
Unknown Object (File)
Thu, May 21, 6:33 AM
Unknown Object (File)
Thu, May 21, 12:35 AM
Unknown Object (File)
Wed, May 20, 8:47 PM
Unknown Object (File)
Sun, May 17, 1:40 AM
Unknown Object (File)
Apr 20 2026, 2:47 AM
Subscribers

Details

Summary

If the directory is empty, then we fail with a message regarding mkdir in
which the empty directory can't be seen because it is not quoted.

Show a nice message so the user knows what is going on.

Test Plan

Apply patch and execute:
bsdinstall jail

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt added a subscriber: bapt.

small style remark, please address before pushing, other that that, lookgs good to me

usr.sbin/bsdinstall/scripts/jail
56

to be consistent with the rest of the code in this script please remove the { and }

This revision is now accepted and ready to land.Oct 18 2023, 6:58 AM
This revision was automatically updated to reflect the committed changes.

Done with the suggested change.

Thanks for the review!