Differential D42198

libprocstat: simplify auxv value conversion
ClosedPublic
Actions

Authored by brooks on Oct 13 2023, 6:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 12, 2:00 AM

	Unknown Object (File)
	Fri, Dec 5, 7:30 AM

	Unknown Object (File)
	Nov 7 2025, 5:39 AM

	Unknown Object (File)
	Nov 6 2025, 11:20 PM

	Unknown Object (File)
	Nov 6 2025, 11:25 AM

	Unknown Object (File)
	Nov 5 2025, 11:27 AM

	Unknown Object (File)
	Nov 4 2025, 11:32 PM

	Unknown Object (File)
	Nov 4 2025, 11:26 PM

View All 68 Files

Subscribers

Details

Reviewers

trociny
markj
jhb

Commits

rG9fcbd4c0d19c: libprocstat: simplify auxv value conversion
rGd65a002ded1f: libprocstat: simplify auxv value conversion
rG9735cc0e4182: libprocstat: simplify auxv value conversion

Summary

Avoid a weird dance through the union and treat all 32-bit values as
unsigned integers. This avoids sign extension of flags and userspace
pointers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Oct 13 2023, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2023, 6:45 PM

brooks requested review of this revision.Oct 13 2023, 6:45 PM

Harbormaster completed remote builds in B53974: Diff 128749.Oct 13 2023, 6:45 PM

brooks added a child revision: D42199: libprocstat: make sv_name not static.Oct 13 2023, 6:45 PM

markj accepted this revision.Oct 13 2023, 6:50 PM

This revision is now accepted and ready to land.Oct 13 2023, 6:50 PM

Closed by commit rG9735cc0e4182: libprocstat: simplify auxv value conversion (authored by brooks). · Explain WhyOct 16 2023, 4:59 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9735cc0e4182: libprocstat: simplify auxv value conversion.

brooks added a commit: rGd65a002ded1f: libprocstat: simplify auxv value conversion.Oct 26 2023, 5:38 PM

brooks added a commit: rG9fcbd4c0d19c: libprocstat: simplify auxv value conversion.Oct 26 2023, 8:39 PM

Revision Contents
Changeset List

Path

Size

lib/

libprocstat/

14 lines

Diff 128841

lib/libprocstat/libprocstat.c

Loading...