libprocstat: copy all the 32-bit auxv entries
ClosedPublic
Actions

Authored by brooks on Oct 13 2023, 6:45 PM.

Details

Reviewers

trociny
markj
jhb

Commits

rGea7f064a780b: libprocstat: copy all the 32-bit auxv entries
rGff90744045e3: libprocstat: copy all the 32-bit auxv entries
rG8f06fabe39ac: libprocstat: copy all the 32-bit auxv entries

Summary

Use source struct size not the destination struct size so we copy all
the auxv entries, not just the first half of them.

Fix a style issue on an adjacent line.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Oct 13 2023, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2023, 6:45 PM

brooks requested review of this revision.Oct 13 2023, 6:45 PM

Harbormaster completed remote builds in B53976: Diff 128751.Oct 13 2023, 6:45 PM

brooks added a parent revision: D42199: libprocstat: make sv_name not static.Oct 13 2023, 6:45 PM

brooks added a child revision: D42201: libprocstat: improve conditional for 32-bit compat.

markj accepted this revision.Oct 13 2023, 6:51 PM

This revision is now accepted and ready to land.Oct 13 2023, 6:51 PM

Closed by commit rG8f06fabe39ac: libprocstat: copy all the 32-bit auxv entries (authored by brooks). · Explain WhyOct 16 2023, 5:00 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG8f06fabe39ac: libprocstat: copy all the 32-bit auxv entries.

brooks added a commit: rGff90744045e3: libprocstat: copy all the 32-bit auxv entries.Oct 26 2023, 5:39 PM

brooks added a commit: rGea7f064a780b: libprocstat: copy all the 32-bit auxv entries.Oct 26 2023, 8:39 PM

Revision Contents
Changeset List

Path

Size

lib/

libprocstat/

libprocstat.c

4 lines

Diff 128843

View Options

lib/libprocstat/libprocstat.c

libprocstat: copy all the 32-bit auxv entriesClosedPublicActions