Page MenuHomeFreeBSD

libprocstat: improve conditional for 32-bit compat
ClosedPublic

Authored by brooks on Oct 13 2023, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 25, 1:38 PM
Unknown Object (File)
Wed, May 22, 4:16 AM
Unknown Object (File)
Wed, May 22, 3:00 AM
Unknown Object (File)
Wed, May 22, 1:19 AM
Unknown Object (File)
May 1 2024, 7:47 PM
Unknown Object (File)
Mar 22 2024, 9:20 PM
Unknown Object (File)
Mar 22 2024, 9:20 PM
Unknown Object (File)
Mar 22 2024, 9:20 PM
Subscribers

Details

Summary

Include support for translating 32-bit auxv vectors on non-64-bit
platforms that aren't riscv (which has no 32-bit ABI support).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I don't see a problem, but why bother hard-coding the platforms that lack 32-bit compat support?

I don't see a problem, but why bother hard-coding the platforms that lack 32-bit compat support?

In this case it's not a lack of 32-bit compat support so much as there will never be 32-bit support. Why compile code gated by an always false, dynamic check? I guess we might end up with an x32 interface if someone really needed the smaller pointer size, but I suspect that would have a different sv_name and this ifdef would be the least of a developer implementing x32's concerns.

This revision is now accepted and ready to land.Oct 13 2023, 7:22 PM