Teach HAS_CONFIGURE how to build outside of source tree similar to USES=cmake:outsource and USES=qmake:outsource. The basic idea can be illustrated as:
$ mkdir ../.build $ cd ../.build $ ${OLDPWD}/configure $ gmake $ gmake install
Differential D4157
Add CONFIGURE_OUTSOURCE support jbeich on Nov 14 2015, 10:43 PM. Authored by Tags None Referenced Files
Details
Teach HAS_CONFIGURE how to build outside of source tree similar to USES=cmake:outsource and USES=qmake:outsource. The basic idea can be illustrated as: $ mkdir ../.build $ cd ../.build $ ${OLDPWD}/configure $ gmake $ gmake install Initial version hooked into USES=autoreconf like devel/fb-adb. Current version is generic and may work with non-autoconf produced configure scripts.
For example, 1-5 can be simplified to $ nice poudriere bulk -Ctj 101i386 \ $(diffstat -l /path/to/this.diff | sed -n '/Mk/d; s,/Makefile,,p') https://people.freebsd.org/~jbeich/D4157/
Diff Detail
Event TimelineComment Actions I think the idea is great, but that USES=autoreconf is the wrong place for this. The output of autoreconf is still inside WRKSRC. It's the output of configure that is moved out so you should implement something like GNU_CONFIGURE=outsource. Comment Actions
Did you miss WRKSRC != CONFIGURE_WRKSRC ? USES=autoreconf currently uses the latter and has to be patched. Moved to D4169.
OK but AUTORECONF_WRKSRC maybe out of sync with CONFIGURE_CMD. Comment Actions
I've somehow reverted D4169 while splitting the diff. Fixed. Comment Actions Ping before 2016Q2. Exp-run in bug 208294.
Comment Actions Replaced example consumers that won't land
with those that will land
Comment Actions lang/gcc* et al. are converted. I've left out marino's and lev's ports as they require more extensive changes:
Comment Actions
Comment Actions Since review is progressing slowly (alas portmgr cannot timeout) I wonder whether to rename CONFIGURE_OUTSOURCE into OUTSOURCE_CONFIGURE. It'd follow the same vein as HAS_CONFIGURE, GNU_CONFIGURE discarding value unlike CONFIGURE_ENV, CONFIGURE_ARGS. Comment Actions Ok, hum:
If you have yes to 1, 2 and 3, and nobody told you "HELL NO!", then 4 should have happened. Comment Actions Mk/ bits stabilized mid November 2015, or the end of March 2016 if you count rename. Finding candidate consumers and converting them to the new style was always optional. A few are still left listed in D4157#122801 + multimedia/handbrake.
Yes per D4157#122622 but before D4157#124286.
None.
Maintainers are supposed to vet changes for style, better approach, etc. If they want to rubberstamp an exp-run then it should be explicit.
I'm confused. Are you implying regular ports/ committers can time out portmgr ? According to Porter's Handbook:
Comment Actions No, I'm not saying that, but there was hardly no answer from anyone, if you're waiting for a rubber stamp saying go ahead, please, go ahead. |