Page MenuHomeFreeBSD

Change default directory used by USES=autoreconf to WRKSRC
ClosedPublic

Authored by jbeich on Nov 15 2015, 7:45 PM.

Details

Test Plan

USES=autoreconf ports that change CONFIGURE_WRKSRC:

  • graphics/p5-ming
  • graphics/py-ming

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich updated this revision to Diff 10209.Nov 15 2015, 7:45 PM
jbeich retitled this revision from to Change default directory used by USES=autoreconf to WRKSRC.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, tijl.
jbeich edited the test plan for this revision. (Show Details)Nov 15 2015, 7:57 PM
jbeich edited edge metadata.
jbeich updated this revision to Diff 10215.Nov 15 2015, 8:40 PM
jbeich edited the test plan for this revision. (Show Details)
  • Fix graphics/p[5y]-ming by not poking USE_GITHUB variables instead of redefining AUTORECONF_WRKSRC
jbeich updated this revision to Diff 10216.Nov 15 2015, 8:48 PM
jbeich edited edge metadata.

Oops, use PATCH_WRKSRC in post-patch to avoid confusion.

tijl accepted this revision.Nov 16 2015, 9:49 AM
tijl edited edge metadata.

For me the patch is fine, but I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch. Since autoreconf runs in WRKSRC it's possible that in the future some files may need to be patched there and then a non-default PATCH_WRKSRC can be a bit confusing or unexpected.

jbeich updated this revision to Diff 10240.Nov 16 2015, 4:02 PM
jbeich edited edge metadata.
In D4169#87753, @tijl wrote:

I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch.

graphics/py-ming already relies on non-default PATCH_WRKSRC as it modifies WRKSRC. I've tried to keep p5-ming consistent with it. However, rebasing the patches would complicate this differential even more.

Let's go back to AUTORECONF_WRKSRC then. Improving p[5y]-ming ports is out of scope here.

jbeich removed a reviewer: sunpoet.Nov 16 2015, 4:03 PM
jbeich updated this revision to Diff 14640.Mar 26 2016, 9:54 PM

Rebased.

This revision was automatically updated to reflect the committed changes.