Page MenuHomeFreeBSD

Change default directory used by USES=autoreconf to WRKSRC
ClosedPublic

Authored by jbeich on Nov 15 2015, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 26, 7:23 PM
Unknown Object (File)
Apr 21 2017, 11:41 AM
Unknown Object (File)
Apr 9 2017, 2:22 AM
Unknown Object (File)
Apr 8 2017, 1:23 AM
Unknown Object (File)
Apr 7 2017, 9:11 PM
Unknown Object (File)
Mar 31 2017, 6:52 PM
Unknown Object (File)
Mar 31 2017, 7:57 AM
Unknown Object (File)
Feb 27 2017, 1:08 AM
Subscribers
None

Details

Test Plan

USES=autoreconf ports that change CONFIGURE_WRKSRC:

  • graphics/p5-ming
  • graphics/py-ming

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich retitled this revision from to Change default directory used by USES=autoreconf to WRKSRC.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, tijl.
jbeich edited edge metadata.
jbeich edited the test plan for this revision. (Show Details)
  • Fix graphics/p[5y]-ming by not poking USE_GITHUB variables instead of redefining AUTORECONF_WRKSRC
jbeich edited edge metadata.

Oops, use PATCH_WRKSRC in post-patch to avoid confusion.

tijl edited edge metadata.

For me the patch is fine, but I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch. Since autoreconf runs in WRKSRC it's possible that in the future some files may need to be patched there and then a non-default PATCH_WRKSRC can be a bit confusing or unexpected.

jbeich edited edge metadata.
In D4169#87753, @tijl wrote:

I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch.

graphics/py-ming already relies on non-default PATCH_WRKSRC as it modifies WRKSRC. I've tried to keep p5-ming consistent with it. However, rebasing the patches would complicate this differential even more.

Let's go back to AUTORECONF_WRKSRC then. Improving p[5y]-ming ports is out of scope here.

This revision was automatically updated to reflect the committed changes.