Page MenuHomeFreeBSD

Make SET_LATE_CONRFIGURE_ARGS work with custom CONFIGURE_CMD
ClosedPublic

Authored by jbeich on Nov 14 2015, 10:52 PM.

Details

Summary

rP383570 likely forgot to run grep(1) over Mk/*. For completeness sake I've converted everything else as well.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich updated this revision to Diff 10181.Nov 14 2015, 10:52 PM
jbeich retitled this revision from to Make SET_LATE_CONRFIGURE_ARGS work with custom CONFIGURE_CMD.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, Perl.

This look good to me for the non-perl part.

jbeich updated this revision to Diff 14639.Mar 26 2016, 9:52 PM
jbeich edited edge metadata.

Rebased.

mat added a subscriber: mat.Mar 27 2016, 9:57 AM

I don't really get what this does, but it looks harmless.

SET_LATE_CONFIGURE_ARGS is used to pass things like --mandir for GNU_CONFIGURE=yes ports but currently doesn't work with CONFIGURE_CMD (unlike CONFIGURE_SCRIPT). D4157 exposes the bug upon more consumers. Notably, lang/gcc will break without this change:

$ make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/info/cpp.info
Error: Orphaned: share/info/cppinternals.info
Error: Orphaned: share/info/gcc.info
Error: Orphaned: share/info/gccinstall.info
Error: Orphaned: share/info/gccint.info
Error: Orphaned: share/info/gfortran.info
Error: Orphaned: share/info/libgomp.info
Error: Orphaned: share/info/libitm.info
Error: Orphaned: share/info/libquadmath.info
Error: Orphaned: share/man/man1/cpp48.1
Error: Orphaned: share/man/man1/g++48.1
Error: Orphaned: share/man/man1/gcc48.1
Error: Orphaned: share/man/man1/gcov48.1
Error: Orphaned: share/man/man1/gfortran48.1
Error: Orphaned: share/man/man7/fsf-funding.7
Error: Orphaned: share/man/man7/gfdl.7
Error: Orphaned: share/man/man7/gpl.7
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: man/man1/cpp48.1.gz
Error: Missing: man/man1/g++48.1.gz
Error: Missing: man/man1/gcc48.1.gz
Error: Missing: man/man1/gcov48.1.gz
Error: Missing: man/man1/gfortran48.1.gz
===> Error: Plist issues found.

This look good to me for the non-perl part.

In D4158#122848, @mat wrote:

I don't really get what this does, but it looks harmless.

Are you giving a weak approval to be rubberstamped after exp-run?

This revision was automatically updated to reflect the committed changes.