Page MenuHomeFreeBSD

Make SET_LATE_CONRFIGURE_ARGS work with custom CONFIGURE_CMD
ClosedPublic

Authored by jbeich on Nov 14 2015, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 1, 3:20 AM
Unknown Object (File)
Sun, Nov 27, 6:28 PM
Unknown Object (File)
Apr 10 2017, 5:47 AM
Unknown Object (File)
Mar 31 2017, 2:52 AM
Unknown Object (File)
Mar 2 2017, 7:42 AM
Unknown Object (File)
Jan 28 2017, 1:54 AM
Unknown Object (File)
Dec 13 2016, 7:22 PM
Unknown Object (File)
Dec 13 2016, 2:59 PM
Subscribers

Details

Summary

rP383570 likely forgot to run grep(1) over Mk/*. For completeness sake I've converted everything else as well.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich retitled this revision from to Make SET_LATE_CONRFIGURE_ARGS work with custom CONFIGURE_CMD.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, Perl.

This look good to me for the non-perl part.

jbeich edited edge metadata.

Rebased.

I don't really get what this does, but it looks harmless.

SET_LATE_CONFIGURE_ARGS is used to pass things like --mandir for GNU_CONFIGURE=yes ports but currently doesn't work with CONFIGURE_CMD (unlike CONFIGURE_SCRIPT). D4157 exposes the bug upon more consumers. Notably, lang/gcc will break without this change:

$ make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/info/cpp.info
Error: Orphaned: share/info/cppinternals.info
Error: Orphaned: share/info/gcc.info
Error: Orphaned: share/info/gccinstall.info
Error: Orphaned: share/info/gccint.info
Error: Orphaned: share/info/gfortran.info
Error: Orphaned: share/info/libgomp.info
Error: Orphaned: share/info/libitm.info
Error: Orphaned: share/info/libquadmath.info
Error: Orphaned: share/man/man1/cpp48.1
Error: Orphaned: share/man/man1/g++48.1
Error: Orphaned: share/man/man1/gcc48.1
Error: Orphaned: share/man/man1/gcov48.1
Error: Orphaned: share/man/man1/gfortran48.1
Error: Orphaned: share/man/man7/fsf-funding.7
Error: Orphaned: share/man/man7/gfdl.7
Error: Orphaned: share/man/man7/gpl.7
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: man/man1/cpp48.1.gz
Error: Missing: man/man1/g++48.1.gz
Error: Missing: man/man1/gcc48.1.gz
Error: Missing: man/man1/gcov48.1.gz
Error: Missing: man/man1/gfortran48.1.gz
===> Error: Plist issues found.

This look good to me for the non-perl part.

In D4158#122848, @mat wrote:

I don't really get what this does, but it looks harmless.

Are you giving a weak approval to be rubberstamped after exp-run?

This revision was automatically updated to reflect the committed changes.