Differential D40956

release: Add code to make FreeBSD/Firecracker
ClosedPublic
Actions

Authored by cperciva on Jul 10 2023, 6:25 AM.

Details

Reviewers

gjb

Group Reviewers

releng

Commits

rG7acb53817ffc: release: Add code to make FreeBSD/Firecracker

Summary

This just stages the kernel and builds a stripped-down rootfs for use
with the Firecracker VMM. At some point in the future the release
engineering team might start publishing these, but initially it's
just here to simplify FreeBSD/Firecracker development and testing.

Note that the rootfs generated:

Uses an IP address of 10.0.0.2 with a gateway of 10.0.0.1,
Has sshd enabled,
Has user "freebsd" with password "freebsd" and a root password of "root", and
Is 1 GB in size (but has growfs enabled).

All of those are subject to change without notice; anyone intending to
use FreeBSD/Firecracker in anything remotely resembling a production
environment should talk to cperciva first.

Sponsored by: https://www.patreon.com/cperciva

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Jul 10 2023, 6:25 AM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptJul 10 2023, 6:25 AM

cperciva requested review of this revision.Jul 10 2023, 6:25 AM

Harbormaster completed remote builds in B52533: Diff 124424.Jul 10 2023, 6:25 AM

0mp added a subscriber: 0mp.Jul 10 2023, 10:51 AM

0mp added inline comments.

release/Makefile.firecracker
3	Shouldn't there be at least a SPDX tag here?
release/Makefile.vm
188	Shouldn't this one go before inc1? Ideally, right after ec2?

gjb added a subscriber: gjb.Jul 10 2023, 3:39 PM

gjb added inline comments.

release/Makefile.firecracker
3	I believe SPDX tags will be going away sometime in the near future.
21	Unless your testing shows otherwise, I believe the contents of WITHOUTS might need to be included in double quotes.
35	Did you intend to use the WITHOUTS variable here?
release/Makefile.vm
188	Agreed. If not for functionality, for consistency.

Move Makefile.firecracker into the right spot.

release/Makefile.firecracker
3	None of the other Makefile.${target} files have copyright statements or SPDX tags. For that matter, neither does src/Makefile. I guess the general src/COPYRIGHT file applies?
21	Testing indeed shows otherwise. If it was shell then we would need quotes; make needs to not have quotes.
35	Not necessary; those are disabling parts of userland. (And it wouldn't matter if extra files got installed into the kernel staging area anyway, since we just pull out the one file we want.)
release/Makefile.vm
188	Err, yes, indeed.

Harbormaster completed remote builds in B52546: Diff 124449.Jul 10 2023, 6:18 PM

gjb accepted this revision.Jul 10 2023, 6:26 PM

gjb added inline comments.

release/Makefile.firecracker
3	A very late afterthought, to be honest, but yes - the intent was to default to "whatever the default license is" - in this case, src/COPYRIGHT.
21	Ah, right. Thank you for the sanity check.
35	Ok, sounds good.