Differential D40356

netlink: use custom uma zone for the mbuf storage
ClosedPublic
Actions

Authored by melifaro on May 31 2023, 6:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 4:54 PM

	Unknown Object (File)
	Wed, Apr 15, 6:27 AM

	Unknown Object (File)
	Tue, Apr 7, 3:11 PM

	Unknown Object (File)
	Tue, Apr 7, 2:23 PM

	Unknown Object (File)
	Tue, Apr 7, 5:10 AM

	Unknown Object (File)
	Mon, Apr 6, 6:35 AM

	Unknown Object (File)
	Fri, Apr 3, 2:04 PM

	Unknown Object (File)
	Wed, Apr 1, 10:53 PM

Subscribers

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers

glebius
markj
adrian
gallatin

Group Reviewers

Commits

rGd18715475071: netlink: use custom uma zone for the mbuf storage.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.May 31 2023, 6:03 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptMay 31 2023, 6:03 PM

melifaro requested review of this revision.May 31 2023, 6:03 PM

Harbormaster completed remote builds in B51811: Diff 122670.May 31 2023, 6:03 PM

melifaro added reviewers: network, glebius, markj, adrian, gallatin.May 31 2023, 6:04 PM

melifaro mentioned this in D40348: netlink: retry mbuf allocation in different pool on failure.

I like this approach

This revision is now accepted and ready to land.May 31 2023, 6:25 PM

nice!

Closed by commit rGd18715475071: netlink: use custom uma zone for the mbuf storage. (authored by melifaro). · Explain WhyJun 1 2023, 7:09 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGd18715475071: netlink: use custom uma zone for the mbuf storage..

Neat, thank you for this one! Probably in stable/14 we will have no errors like the one below from stable/13.
[703139] [nl_io] PID 64148 nl_on_transmit: socket RX overflowed, 218 messages (18848 bytes) dropped. bytes: [202095524/805306368] mbufs: [1073741312/1073741824]

melifaro mentioned this in D40368: netlink: use netlink mbufs in the mbuf chains..Jun 1 2023, 8:15 AM

melifaro mentioned this in rGc1839039b193: netlink: use netlink mbufs in the mbuf chains..Jun 2 2023, 1:19 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

netlink_message_writer.c

78 lines

netlink_module.c

2 lines

10 lines

Diff 122688

sys/netlink/netlink_message_writer.c

Loading...

sys/netlink/netlink_module.c

Loading...

sys/netlink/netlink_var.h

Loading...