Page MenuHomeFreeBSD
Differential D40229

tcp: request tracking is not http specific.
ClosedPublic
Actions

Authored by rrs on May 23 2023, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 11:21 PM
Unknown Object (File)
Feb 18 2024, 8:30 AM
Unknown Object (File)
Dec 12 2023, 7:45 AM
Unknown Object (File)
Dec 7 2023, 9:27 PM
Unknown Object (File)
Dec 5 2023, 9:19 AM
Unknown Object (File)
Dec 5 2023, 8:50 AM
Unknown Object (File)
Dec 5 2023, 1:06 AM
Unknown Object (File)
Nov 8 2023, 10:03 AM
View All 42 Files
Subscribers
agh_riseup.net
glebius
imp
melifaro

Details

Reviewers
tuexen
antoine
Group Reviewers
transport
Commits
rG57a3a161a92f: tcp: request tracking is not http specific.
Summary

This change is a name change only. TCP Request tracking can track sendfile and even non-sendfile requests. The
names however in the current code use http, and they should not. The feature is not http specific. Lets change the
name so they more properly reflect whats going on. This also fixes conflicts with http_req which caused application pain.

Test Plan

make sure we compile after the name change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rrs created this revision.May 23 2023, 1:58 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMay 23 2023, 1:58 PM
Herald added subscribers: glebius, melifaro. · View Herald Transcript
rrs requested review of this revision.May 23 2023, 1:58 PM
tuexen accepted this revision.May 23 2023, 9:22 PM
tuexen added inline comments.
sys/netinet/tcp_log_buf.c
2

Is it intended to add an empty first line in the file?

This revision is now accepted and ready to land.May 23 2023, 9:22 PM
agh_riseup.net added a subscriber: agh_riseup.net.May 23 2023, 11:58 PM
Closed by commit rG57a3a161a92f: tcp: request tracking is not http specific. (authored by rrs). · Explain WhyMay 24 2023, 2:35 PM
This revision was automatically updated to reflect the committed changes.
rrs added a commit: rG57a3a161a92f: tcp: request tracking is not http specific..
Herald added a subscriber: imp. · View Herald TranscriptMay 24 2023, 2:35 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
6 lines
6 lines
37 lines
tcp_stacks/
130 lines
2 lines
198 lines
66 lines

Diff 122372

View Options

sys/netinet/tcp.h

Loading...
View Options

sys/netinet/tcp_log_buf.h

Loading...
View Options

sys/netinet/tcp_log_buf.c

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...
View Options

sys/netinet/tcp_stacks/tcp_rack.h

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...