Page MenuHomeFreeBSD

linux(4): Check fd passed to unlockpt()
ClosedPublic

Authored by dchagin on May 14 2023, 11:18 PM.
Referenced Files
Unknown Object (File)
Jan 20 2025, 9:10 PM
Unknown Object (File)
Jan 15 2025, 10:34 PM
Unknown Object (File)
Jan 11 2025, 7:21 AM
Unknown Object (File)
Jan 11 2025, 2:46 AM
Unknown Object (File)
Dec 30 2024, 1:28 AM
Unknown Object (File)
Oct 25 2024, 5:27 PM
Unknown Object (File)
Oct 2 2024, 12:09 PM
Unknown Object (File)
Sep 29 2024, 10:21 PM
Subscribers

Details

Summary

In our implementation, grantpt() and unlockpt() don't actually have
any use, because PTY's are created on the fly and already have proper
permissions upon creation.
Atleast check that a proper fd passed to unlockpt(). For grantpt()
Glibc calls TIOCGPTN ioctl which would fail if fd is not a master.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51496
Build 48387: arc lint + arc unit