Page MenuHomeFreeBSD
Differential D39956

dtrace: add register bindings for arm64
ClosedPublic
Actions

Authored by christos on May 4 2023, 1:44 PM.
Tags
Referenced Files
F101874458: D39956.id.diff
Tue, Nov 5, 1:03 AM
Unknown Object (File)
Mon, Oct 28, 6:13 PM
Unknown Object (File)
Mon, Oct 28, 6:11 PM
Unknown Object (File)
Mon, Oct 28, 6:11 PM
Unknown Object (File)
Mon, Oct 28, 6:11 PM
Unknown Object (File)
Mon, Oct 28, 6:11 PM
Unknown Object (File)
Sep 19 2024, 3:10 PM
Unknown Object (File)
Sep 11 2024, 1:38 AM
View All 86 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
markj
mhorne
gnn
Group Reviewers
arm64
Commits
rG21a16d55cc15: dtrace: add register bindings for arm64
Summary

Depends on D39955

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.May 4 2023, 1:44 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 4 2023, 1:44 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
christos requested review of this revision.May 4 2023, 1:44 PM
markj added a reviewer: arm64.May 4 2023, 1:51 PM
mhorne added inline comments.May 4 2023, 2:29 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

I suggest renaming rp to the more typical tf.

283–297

tf_x[] has 30 elements, therefore only indices 0 to 29.

christos updated this revision to Diff 121504.May 4 2023, 2:35 PM
christos marked 2 inline comments as done.

Address Mitchell's comments.

christos added inline comments.May 4 2023, 2:37 PM
sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

I'll submit a different patch that changes rp to tf or frame across all architectures.

mhorne accepted this revision.May 4 2023, 2:41 PM

LGTM

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
281

Sounds great!

This revision is now accepted and ready to land.May 4 2023, 2:41 PM
christos marked an inline comment as done.May 4 2023, 2:47 PM
markj accepted this revision.May 22 2023, 8:03 PM

Approved (with the suggested change applied)

sys/cddl/dev/dtrace/aarch64/regset.h
75

so that this doesn't look like a typo at first glance

Closed by commit rG21a16d55cc15: dtrace: add register bindings for arm64 (authored by christos). · Explain WhyMay 23 2023, 2:20 PM
This revision was automatically updated to reflect the committed changes.
christos marked an inline comment as done.
christos added a commit: rG21a16d55cc15: dtrace: add register bindings for arm64.
christos removed a parent revision: D39955: dtrace: implement dtrace_instr_size() for arm64.May 23 2023, 2:22 PM

Revision Contents
Changeset List

PathSize
cddl/
lib/
libdtrace/
1 line
74 lines
sys/
cddl/
dev/
dtrace/
aarch64/
18 lines
35 lines

Diff 122296

View Options

cddl/lib/libdtrace/Makefile

Loading...
View Options

cddl/lib/libdtrace/regs_aarch64.d

Loading...
View Options

sys/cddl/dev/dtrace/aarch64/dtrace_isa.c

Loading...
View Options

sys/cddl/dev/dtrace/aarch64/regset.h

Loading...