Page MenuHomeFreeBSD

armv7: release: Stop installing BBB u-boot
ClosedPublic

Authored by manu on Apr 27 2023, 6:23 AM.
Tags
None
Referenced Files
F133009277: D39844.diff
Wed, Oct 22, 12:56 AM
Unknown Object (File)
Thu, Oct 16, 2:55 AM
Unknown Object (File)
Thu, Oct 16, 2:55 AM
Unknown Object (File)
Thu, Oct 16, 2:55 AM
Unknown Object (File)
Thu, Oct 16, 2:55 AM
Unknown Object (File)
Wed, Oct 15, 4:00 PM
Unknown Object (File)
Fri, Oct 10, 11:40 PM
Unknown Object (File)
Sat, Sep 27, 11:51 PM

Details

Summary

BBB code was removed from GENERIC kernel as it's not functional.
Stop installing u-boot for a platform that we don't boot on.

MFC after: never
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Apr 27 2023, 6:23 AM

I hate to see it go... but on the other hand my hate isn't for it leaving, but that the support for it in -current has decayed too much

This revision is now accepted and ready to land.Apr 27 2023, 5:50 PM
gjb requested changes to this revision.Apr 27 2023, 6:02 PM
gjb added a subscriber: gjb.
gjb added inline comments.
release/arm/GENERICSD.conf
51–52

Why not just get rid of the arm_install_uboot_bbb() call here, and remove the function entirely? It is not used anywhere else.

This revision now requires changes to proceed.Apr 27 2023, 6:02 PM
release/arm/GENERICSD.conf
51–52

Indeed, will do that tomorow.

release/arm/GENERICSD.conf
51–52

As part of this review?

release/arm/GENERICSD.conf
51–52

Yes, it's better to remove everything BBB related in release/ in one commit. Also easier if someone wants to work on this platform to revert only 1 or 2 commits

Remove arm_install_uboot_bbb too

manu marked 2 inline comments as done.Apr 28 2023, 8:07 PM
This revision is now accepted and ready to land.Apr 28 2023, 8:39 PM
This revision was automatically updated to reflect the committed changes.