Page MenuHomeFreeBSD

arm64: Add a bus_describe_intr() implementation for nexus
ClosedPublic

Authored by markj on Apr 21 2023, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 5:23 PM
Unknown Object (File)
Jan 18 2024, 1:19 PM
Unknown Object (File)
Jan 5 2024, 5:47 PM
Unknown Object (File)
Dec 29 2023, 3:09 AM
Unknown Object (File)
Dec 23 2023, 1:48 AM
Unknown Object (File)
Oct 6 2023, 4:48 AM
Unknown Object (File)
Sep 10 2023, 1:06 PM
Unknown Object (File)
Aug 15 2023, 12:19 AM
Subscribers

Details

Summary

Prompted by a compiler warning introduced by
e582d4a2b09e ("arm64: nexus code tidy-up").

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Apr 21 2023, 3:08 PM

Sure, but it should be done for riscv as well. This method is not widely used but we may as well have it.

sys/arm64/arm64/nexus.c
123

I see. This was a copy-paste error.

This revision is now accepted and ready to land.Apr 21 2023, 3:21 PM

Sure, but it should be done for riscv as well.

Ok.

This method is not widely used but we may as well have it.

On my test platform it's used only by nvme. Now vmstat -i shows:

its0,0: nvme0:admin                                      25          0
its0,1: nvme0:io0                                       439          8
its0,2: nvme0:io1                                       330          6
its0,3: nvme0:io2                                       452          8
its0,4: nvme0:io3                                       574         10
its0,5: nvme0:io4                                       443          8
its0,6: nvme0:io5                                       634         11
its0,7: nvme0:io6                                       360          6
its0,8: nvme0:io7                                       321          6

whereas before it was:

its0,0: nvme0                                            25          0
its0,1: nvme0                                          2991          8
its0,2: nvme0                                          3325          9
its0,3: nvme0                                          2945          8
its0,4: nvme0                                          2809          8
its0,5: nvme0                                          3615         10
its0,6: nvme0                                          2940          8
its0,7: nvme0                                          2750          7
its0,8: nvme0                                          3208          9
This revision was automatically updated to reflect the committed changes.