Page MenuHomeFreeBSD
Differential D39489

dtrace: expose dtrace_instr_size() to userland and implement it for RISC-V
ClosedPublic
Actions

Authored by christos on Apr 10 2023, 5:38 PM.
Tags
Referenced Files
Unknown Object (File)
Mar 8 2024, 12:33 AM
Unknown Object (File)
Mar 8 2024, 12:28 AM
Unknown Object (File)
Mar 8 2024, 12:28 AM
Unknown Object (File)
Mar 8 2024, 12:27 AM
Unknown Object (File)
Mar 8 2024, 12:27 AM
Unknown Object (File)
Mar 8 2024, 12:27 AM
Unknown Object (File)
Mar 8 2024, 12:27 AM
Unknown Object (File)
Mar 8 2024, 12:27 AM
View All 41 Files
Subscribers
imp
riscv

Details

Reviewers
markj
mhorne
gnn
Commits
rG4d9000cb22a9: dtrace: expose dtrace_instr_size() to userland and implement it for riscv
rG080e56a6c98c: dtrace: expose dtrace_instr_size() to userland and implement it for riscv
Summary

dtrace_instr_size() is needed by the forthcoming RISC-V port of kinst, as
well as by libdtrace in D38825 for both amd64 and RISC-V.

Depend on D39490.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Apr 10 2023, 5:38 PM
Herald added a reviewer: gnn. · View Herald TranscriptApr 10 2023, 5:38 PM
Herald added a subscriber: imp. · View Herald Transcript
christos requested review of this revision.Apr 10 2023, 5:38 PM
christos mentioned this in D38825: libdtrace: implement inline function tracing for kinst.Apr 10 2023, 5:45 PM
christos added a child revision: D38825: libdtrace: implement inline function tracing for kinst.
christos updated this revision to Diff 120105.Apr 10 2023, 5:56 PM
christos edited the summary of this revision. (Show Details)
christos updated this revision to Diff 120109.Apr 10 2023, 6:19 PM
christos edited the summary of this revision. (Show Details)
christos added a parent revision: D39490: dtrace: get rid of uchar_t types.
christos updated this revision to Diff 120113.Apr 10 2023, 7:18 PM

Provide full diff.

markj added inline comments.Apr 10 2023, 7:40 PM
sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h
58

Why did you move this above all of the #includes? Typically includes will come first.

christos updated this revision to Diff 120121.Apr 10 2023, 8:44 PM
christos marked an inline comment as done.

Compile instr_size.c into libdtrace and dtrace, move definition below KERNEL ifdef.

christos updated this revision to Diff 120124.Apr 10 2023, 10:00 PM
christos edited the summary of this revision. (Show Details)

Merge and abandon D39490.

christos updated this revision to Diff 120125.Apr 10 2023, 10:02 PM
christos removed a parent revision: D39490: dtrace: get rid of uchar_t types.Apr 10 2023, 10:04 PM
mhorne added a comment.Apr 12 2023, 6:46 PM

Thanks for working on this!

I would prefer to see the uchar_t changes separated from riscv additions, if possible.

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h
54

The presence of sys/param.h makes the include of sys/types.h redundant. Per style(9), only one or the other should be included.

christos updated this revision to Diff 120309.Apr 14 2023, 1:51 PM
christos edited the summary of this revision. (Show Details)
christos marked an inline comment as done.
christos added a parent revision: D39490: dtrace: get rid of uchar_t types.
mhorne accepted this revision.Apr 14 2023, 3:13 PM
This revision is now accepted and ready to land.Apr 14 2023, 3:13 PM
christos added a child revision: D39611: dtrace: add register bindings for RISC-V.Apr 17 2023, 2:01 AM
christos added a child revision: D39652: riscv/dtrace_subr.c: use dtrace_instr_size().Apr 18 2023, 12:47 PM
Closed by commit rG080e56a6c98c: dtrace: expose dtrace_instr_size() to userland and implement it for riscv (authored by christos, committed by markj). · Explain WhyApr 20 2023, 5:37 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG080e56a6c98c: dtrace: expose dtrace_instr_size() to userland and implement it for riscv.
christos removed a child revision: D38825: libdtrace: implement inline function tracing for kinst.Apr 27 2023, 3:38 PM
markj added a commit: rG4d9000cb22a9: dtrace: expose dtrace_instr_size() to userland and implement it for riscv.May 7 2023, 6:01 PM
Herald added a subscriber: riscv. · View Herald TranscriptMay 7 2023, 6:01 PM

Revision Contents
Changeset List

PathSize
cddl/
lib/
libdtrace/
6 lines
sys/
cddl/
contrib/
opensolaris/
uts/
common/
sys/
5 lines
dev/
dtrace/
riscv/
22 lines
modules/
dtrace/
dtrace/
4 lines

Diff 120742

View Options

cddl/lib/libdtrace/Makefile

Loading...
View Options

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h

Loading...
View Options

sys/cddl/dev/dtrace/riscv/instr_size.c

Loading...
View Options

sys/modules/dtrace/dtrace/Makefile

Loading...