Page MenuHomeFreeBSD

dtrace: expose dtrace_instr_size() to userland and implement it for RISC-V
ClosedPublic

Authored by christos on Apr 10 2023, 5:38 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jul 6, 6:03 AM
Unknown Object (File)
Fri, Jun 28, 3:05 AM
Unknown Object (File)
Thu, Jun 27, 5:59 PM
Unknown Object (File)
Thu, Jun 27, 4:02 PM
Unknown Object (File)
Thu, Jun 27, 3:20 PM
Unknown Object (File)
Thu, Jun 27, 2:56 PM
Unknown Object (File)
Thu, Jun 27, 2:55 PM
Unknown Object (File)
Thu, Jun 27, 2:55 PM
Subscribers

Details

Summary

dtrace_instr_size() is needed by the forthcoming RISC-V port of kinst, as
well as by libdtrace in D38825 for both amd64 and RISC-V.

Depend on D39490.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos edited the summary of this revision. (Show Details)
christos edited the summary of this revision. (Show Details)
sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h
58

Why did you move this above all of the #includes? Typically includes will come first.

christos marked an inline comment as done.

Compile instr_size.c into libdtrace and dtrace, move definition below KERNEL ifdef.

christos edited the summary of this revision. (Show Details)

Merge and abandon D39490.

Thanks for working on this!

I would prefer to see the uchar_t changes separated from riscv additions, if possible.

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h
54

The presence of sys/param.h makes the include of sys/types.h redundant. Per style(9), only one or the other should be included.

christos edited the summary of this revision. (Show Details)
christos marked an inline comment as done.
This revision is now accepted and ready to land.Apr 14 2023, 3:13 PM