Page MenuHomeFreeBSD

netlink: use process threads
Needs ReviewPublic

Authored by melifaro on Mar 21 2023, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 5:48 AM
Unknown Object (File)
Sat, Apr 27, 5:48 AM
Unknown Object (File)
Sat, Apr 27, 3:52 AM
Unknown Object (File)
Dec 27 2023, 11:01 PM
Unknown Object (File)
Oct 26 2023, 7:02 PM
Unknown Object (File)
Jun 12 2023, 10:42 AM
Unknown Object (File)
May 15 2023, 5:38 AM
Unknown Object (File)
Apr 26 2023, 3:31 PM

Details

Reviewers
kib

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50491
Build 47382: arc lint + arc unit

Event Timeline

  1. Block all blockable signals on the thread start.
  2. You need to handle a situation where the netlink thread goes away while you are trying to schedule a task for it
  3. Are netlink socket passable between processes? What should happen if you pass the socket and the receiving process start issuing requests to the other process' socket?
sys/netlink/netlink_domain.c
49

Properly move this to the include block above. But why do you need this header at all?

279

I think these blank lines are not needed.

sys/netlink/netlink_io.c
313

for (;;) {

315
if (error != 0 || thread_check_susp(curthread, true) != 0)
    NLP_LOCK();
    break;
}