Page MenuHomeFreeBSD
Differential D39046

net: refactor if_clone.c #1
ClosedPublic
Actions

Authored by melifaro on Mar 13 2023, 10:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 8:25 PM
Unknown Object (File)
Tue, Nov 25, 7:24 PM
Unknown Object (File)
Tue, Nov 25, 5:03 PM
Unknown Object (File)
Sun, Nov 23, 1:03 AM
Unknown Object (File)
Nov 11 2025, 9:39 PM
Unknown Object (File)
Nov 7 2025, 2:08 AM
Unknown Object (File)
Nov 2 2025, 12:43 AM
Unknown Object (File)
Nov 1 2025, 3:51 AM
View All Files
Subscribers
ae
glebius
imp

Details

Reviewers
kp
glebius
Group Reviewers
network
Commits
rG83b5c80c6923: net: refactor if_clone.c #1
Summary
  • Add ifc_find_cloner()
  • Rename current ifc_find_cloner() to ifc_find_cloner_vnet()
  • Add ifc_find_cloner_match()

This change simplifies the code a bit and reduces the diff to
the netlink interface cloners merge (D39032).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50318
Build 47210: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 13 2023, 10:44 AM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMar 13 2023, 10:44 AM
melifaro requested review of this revision.Mar 13 2023, 10:44 AM
Harbormaster completed remote builds in B50318: Diff 118723.Mar 13 2023, 10:44 AM
melifaro added reviewers: network, kp.Mar 13 2023, 10:44 AM
melifaro updated this revision to Diff 118724.Mar 13 2023, 10:45 AM

.

Harbormaster completed remote builds in B50319: Diff 118724.Mar 13 2023, 10:45 AM
kp accepted this revision as: kp.Mar 13 2023, 12:51 PM

Two non-blocking remarks.

sys/net/if_clone.c
199

That declaration probably needs to be before int error; in line 196, and separated from the assignment.

296

Would ifc_find_cloner_in_vnet() be better?

This revision is now accepted and ready to land.Mar 13 2023, 12:51 PM
glebius accepted this revision as: glebius.Mar 13 2023, 7:24 PM
glebius added inline comments.
sys/net/if_clone.c
199

+1 on that

Closed by commit rG83b5c80c6923: net: refactor if_clone.c #1 (authored by melifaro). · Explain WhyMar 15 2023, 1:56 PM
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG83b5c80c6923: net: refactor if_clone.c #1.

Revision Contents
Changeset List

PathSize
sys/
net/
41 lines

Diff 118723

View Options

sys/net/if_clone.c

Loading...