Page MenuHomeFreeBSD
Differential D38822

netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option
ClosedPublic
Actions

Authored by markj on Feb 28 2023, 2:03 PM.
Tags
None
Referenced Files
F87094025: D38822.diff
Sat, Jun 29, 6:33 AM
Unknown Object (File)
May 22 2024, 3:07 PM
Unknown Object (File)
May 22 2024, 4:55 AM
Unknown Object (File)
May 21 2024, 8:05 PM
Unknown Object (File)
May 21 2024, 8:05 PM
Unknown Object (File)
May 21 2024, 2:35 PM
Unknown Object (File)
May 4 2024, 8:38 PM
Unknown Object (File)
May 2 2024, 10:55 PM
View All 37 Files
Subscribers
ae
imp
melifaro
mjg

Details

Reviewers
glebius
mjg
Group Reviewers
network
Commits
rG317fa5169d35: netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option
Summary

It has no effect, and an exp-run revealed that it is not in use.

No functional change intended.

PR: 261398 (exp-run)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50062
Build 46954: arc lint + arc unit

Event Timeline

markj created this revision.Feb 28 2023, 2:03 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 28 2023, 2:03 PM
markj requested review of this revision.Feb 28 2023, 2:03 PM
Harbormaster completed remote builds in B50062: Diff 118076.Feb 28 2023, 2:03 PM
markj added a parent revision: D38821: librss: Remove rss_socket_set_rss_bucket().Feb 28 2023, 2:03 PM
mjg added a subscriber: mjg.Feb 28 2023, 2:08 PM
mjg added inline comments.
sys/netinet/in_pcb.h
674

unused opts are denoted with an explicit comment, so this should be

/*                              0x00000080 */

something to that extent should probably be also slapped in the IP_RSS_LISTEN_BUCKET case

mjg added inline comments.Feb 28 2023, 2:10 PM
sys/netinet/in_pcb.h
674

same with IPV6_RSS_LISTEN_BUCKET even though that one already has unannotated gaps

markj updated this revision to Diff 118078.Feb 28 2023, 2:15 PM
markj marked an inline comment as done.

Add comments for removed socket options and inpcb flags.

Harbormaster completed remote builds in B50063: Diff 118078.Feb 28 2023, 2:15 PM
markj marked an inline comment as done.Feb 28 2023, 2:15 PM
mjg accepted this revision.Feb 28 2023, 2:21 PM
This revision is now accepted and ready to land.Feb 28 2023, 2:21 PM
markj updated this revision to Diff 118079.Feb 28 2023, 2:28 PM

Remove a case that I missed.

This revision now requires review to proceed.Feb 28 2023, 2:28 PM
Harbormaster completed remote builds in B50064: Diff 118079.Feb 28 2023, 2:28 PM
glebius accepted this revision as: glebius.Feb 28 2023, 4:14 PM
This revision is now accepted and ready to land.Feb 28 2023, 4:14 PM
Closed by commit rG317fa5169d35: netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option (authored by markj). · Explain WhyFeb 28 2023, 9:06 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG317fa5169d35: netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option.

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line
4 lines
1 line
11 lines
netinet6/
1 line
16 lines

Diff 118076

View Options

sys/netinet/in.h

Loading...
View Options

sys/netinet/in_pcb.h

Loading...
View Options

sys/netinet/in_pcb.c

Loading...
View Options

sys/netinet/ip_output.c

Loading...
View Options

sys/netinet6/in6.h

Loading...
View Options

sys/netinet6/ip6_output.c

Loading...