mlx5: Enter network epoch when using if_foreach()
ClosedPublic
Actions

Authored by jhibbits on Feb 21 2023, 9:09 PM.

Details

Reviewers

glebius
• hselasky

Group Reviewers

network

Commits

rG70510800d1ad: mlx5: Enter network epoch when using if_foreach()

Summary

IFNET_RLOCK() is not sufficient, the epoch needs entered.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Feb 21 2023, 9:09 PM

Herald added subscribers: ae, imp. · View Herald TranscriptFeb 21 2023, 9:09 PM

jhibbits requested review of this revision.Feb 21 2023, 9:09 PM

Harbormaster completed remote builds in B49931: Diff 117708.Feb 21 2023, 9:09 PM

Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!

#define write_lock(_l)          rw_wlock(&(_l)->rw)

In D38711#881214, @hselasky wrote:
Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!
#define write_lock(_l)          rw_wlock(&(_l)->rw)

Or am I wrong.

--HPS

In D38711#881221, @hselasky wrote:
In D38711#881214, @hselasky wrote:
Hi,

I'm not sure if that will work, because there is a write_lock() inside mlx5_enable_roce_if_cb(), and that cannot be used inside an EPOCH section!
#define write_lock(_l)          rw_wlock(&(_l)->rw)
Or am I wrong.

--HPS

It's OK to use rwlocks/mutexes (and basically anything that don't sleep) in the (network) epoch.

I'm good with this patch!

This revision is now accepted and ready to land.Feb 22 2023, 10:42 AM

Closed by commit rG70510800d1ad: mlx5: Enter network epoch when using if_foreach() (authored by jhibbits). · Explain WhyMar 6 2023, 4:24 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rG70510800d1ad: mlx5: Enter network epoch when using if_foreach().

Revision Contents
Changeset List

Path

Size

sys/

dev/

mlx5/

mlx5_ib/

mlx5_ib_main.c

5 lines

Diff 118400

View Options

sys/dev/mlx5/mlx5_ib/mlx5_ib_main.c

mlx5: Enter network epoch when using if_foreach()ClosedPublicActions