Differential D38073

[asmc] Add Macbook 6,2
ClosedPublic
Actions

Authored by adrian on Jan 16 2023, 5:37 AM.

Details

Reviewers

markj

Commits

rGffc58e2ca365: asmc: Add MacbookAir6,2

Summary

Add in the zones for the macbook 6.2, which matches my macbook air 2013.

Test Plan

compiled on -HEAD, run on my Macbook Air 2013 model.
verified temperatures mostly look sane, and the keyboard light control works fine

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Jan 16 2023, 5:37 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2023, 5:37 AM

adrian requested review of this revision.Jan 16 2023, 5:37 AM

adrian added a reviewer: markj.Jan 16 2023, 4:31 PM

adrian added inline comments.

sys/dev/asmc/asmc.c
425	lol i'll remove this in the next revision of this diff, ha.

Seems fine to me, just a couple of style nits. If it works, I think you can just go ahead and commit with the nits fixed.

sys/dev/asmc/asmc.c
432	Looks like this shouldn't be part of the diff.
sys/dev/asmc/asmcvar.h
775	Extra newline.

This revision is now accepted and ready to land.Jan 16 2023, 4:34 PM

addressed nits

This revision now requires review to proceed.Jan 19 2023, 2:50 AM

adrian marked an inline comment as done.Jan 19 2023, 2:50 AM

markj accepted this revision.Jan 19 2023, 2:52 PM

This revision is now accepted and ready to land.Jan 19 2023, 2:52 PM

Closed by commit rGffc58e2ca365: asmc: Add MacbookAir6,2 (authored by adrian). · Explain WhyJan 21 2023, 4:44 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGffc58e2ca365: asmc: Add MacbookAir6,2.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

asmc.c

9 lines

asmcvar.h

25 lines

Diff 115383

View Options

sys/dev/asmc/asmc.c