network.subr: Fix infinite loop

[cy]

Summary

When setting up carp tunnel, using a password consisting of only the characters used as hexadecimal characters, i.e. abc-def, there will be an infinite loop in the shell function ifalias_af_common_handler(). To circumvent this we test for " pass ".

See PR/268378 for details.

This patch now includes globally replacing

\

with

[[:space]]

as suggested by eugen@.

Test Plan

Tested by PR submitter and by myself

[eugen_grosbein.net]

May I suggest to use

[[:space:]]

instead of

\

?

Just like clone_up() does it already.

[cy]

In D37748#858710, @eugen_grosbein.net wrote:

May I suggest to use

[[:space:]]

instead of

\

?

Just like clone_up() does it already.

Good idea. This change of course will need two commits then. One to fix the other lines in the case structure. The second to add this patch. I'll resubmit both commits as one patch to this review.

[cy]

This new diff incorporates eugen@'s suggestion to use :space by replacing all "\ " with ":space" and fixing the original bug. This is two commits in my local repo.

[cy]

In D37748#859180, @cy wrote:

In D37748#858710, @eugen_grosbein.net wrote:

May I suggest to use

[[:space:]]

instead of

\

?

Just like clone_up() does it already.

Good idea. This change of course will need two commits then. One to fix the other lines in the case structure. The second to add this patch. I'll resubmit both commits as one patch to this review.

Not a good idea. :space is a bashism not supported by Bourne. I'll replace the \[\[:space\]\] with "\ ".

[cy]

In D37748#859193, @cy wrote:

In D37748#859180, @cy wrote:

In D37748#858710, @eugen_grosbein.net wrote:

May I suggest to use

[[:space:]]

instead of

\

?

Just like clone_up() does it already.

Good idea. This change of course will need two commits then. One to fix the other lines in the case structure. The second to add this patch. I'll resubmit both commits as one patch to this review.

Not a good idea. :space is a bashism not supported by Bourne. I'll replace the \[\[:space\]\] with "\ ".

My mistake. I used the bashism instead of the Bourne supported syntax.

[cy]

This uses the correct Bourne syntax instead of the bashism syntax. Sorry for the spam.