if_ovpn: remove OVPN_SEND_PKT
ClosedPublic
Actions

Authored by kp on Dec 5 2022, 4:29 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG66de89d4c298: if_ovpn: remove OVPN_SEND_PKT

Summary

OpenVPN userspace no longer uses the ioctl interface to send control
packets. It instead uses the socket directly.
The use of OVPN_SEND_PKT was never released, so we can remove this
without worrying about compatibility.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 5 2022, 4:29 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptDec 5 2022, 4:29 PM

kp requested review of this revision.Dec 5 2022, 4:29 PM

Harbormaster completed remote builds in B48612: Diff 113835.Dec 5 2022, 4:30 PM

OpenVPN userspace no longer uses the ioctl interface to send control packets.

Is the ioctl interface needed for compatibility with older version of OpenVPN userspace ?

In D37602#855154, @zlei wrote:

OpenVPN userspace no longer uses the ioctl interface to send control packets.

Is the ioctl interface needed for compatibility with older version of OpenVPN userspace ?

Only development versions of OpenVPN used this call. The first release version that includes DCO support (for any platform in fact) will be 2.6.0, expected to be released late this month.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2022, 5:50 AM

Closed by commit rG66de89d4c298: if_ovpn: remove OVPN_SEND_PKT (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG66de89d4c298: if_ovpn: remove OVPN_SEND_PKT.