Page MenuHomeFreeBSD
Differential D37548

ipfilter: Fix mismatch in array bounds.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 10:41 PM
Unknown Object (File)
Wed, Oct 15, 1:56 AM
Unknown Object (File)
Sat, Oct 11, 9:36 AM
Unknown Object (File)
Sat, Oct 11, 9:36 AM
Unknown Object (File)
Sat, Oct 11, 9:36 AM
Unknown Object (File)
Sat, Oct 11, 1:57 AM
Unknown Object (File)
Sep 19 2025, 6:14 AM
Unknown Object (File)
Sep 17 2025, 3:24 AM
View All 77 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
emaste
cy
imp
Commits
rG415ccf51122e: ipfilter: Fix mismatch in array bounds.
Summary

Reported by: GCC -Warray-parameter

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 29 2022, 7:57 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptNov 29 2022, 7:57 PM
jhb requested review of this revision.Nov 29 2022, 7:57 PM
jhb added a parent revision: D37547: aesni: Remove misleading array bounds for aesni_decryt_ecb..
Harbormaster completed remote builds in B48549: Diff 113635.Nov 29 2022, 7:58 PM
jhb added a child revision: D37549: mlx5: Fix mismatch in array bounds..Nov 29 2022, 7:58 PM
jhb added a reviewer: cy.Nov 29 2022, 8:03 PM
imp accepted this revision.Nov 29 2022, 8:22 PM
imp added inline comments.
sys/netpfil/ipfilter/netinet/radix_ipf.c
321

Is '2' the right way to spell [2] here? :)

This revision is now accepted and ready to land.Nov 29 2022, 8:22 PM
jhb added inline comments.Nov 29 2022, 9:39 PM
sys/netpfil/ipfilter/netinet/radix_ipf.c
33

It matches the spelling here, so yes. :)

jhb added inline comments.Nov 29 2022, 9:40 PM
sys/netpfil/ipfilter/netinet/radix_ipf.c
363

This function is also full of explicit nodes[0] and nodes[1] references with magic numbers.

imp added inline comments.Nov 29 2022, 10:01 PM
sys/netpfil/ipfilter/netinet/radix_ipf.c
363

Sounds good to go then. Thanks for the reason.

cy accepted this revision.Nov 30 2022, 10:15 PM
cy added inline comments.
sys/netpfil/ipfilter/netinet/radix_ipf.c
363

It is. Input and output.

BTW I am in the process of rewriting this source file to support IPv6.

emaste accepted this revision.Dec 2 2022, 10:49 PM
Closed by commit rG415ccf51122e: ipfilter: Fix mismatch in array bounds. (authored by jhb). · Explain WhyDec 7 2022, 8:34 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG415ccf51122e: ipfilter: Fix mismatch in array bounds..

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfilter/
netinet/
2 lines

Diff 113923

View Options

sys/netpfil/ipfilter/netinet/radix_ipf.c

Loading...