Page MenuHomeFreeBSD
Differential D37547

aesni: Remove misleading array bounds for aesni_decryt_ecb.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:57 PM.
Tags
None
Referenced Files
F154290022: D37547.id.diff
Mon, Apr 27, 3:34 PM
F154284131: D37547.id113922.diff
Mon, Apr 27, 2:38 PM
Unknown Object (File)
Fri, Apr 24, 5:00 AM
Unknown Object (File)
Mar 19 2026, 6:40 AM
Unknown Object (File)
Mar 19 2026, 6:33 AM
Unknown Object (File)
Mar 18 2026, 4:22 PM
Unknown Object (File)
Mar 16 2026, 4:00 AM
Unknown Object (File)
Mar 16 2026, 4:00 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
imp
Commits
rG22cb9d3f17c4: aesni: Remove misleading array bounds for aesni_decryt_ecb.
rGd256a06fe8bd: aesni: Remove misleading array bounds for aesni_decryt_ecb.
Summary

All the other functions used pointers for from/to instead of
fixed-size array parameters. More importantly, this function can
accept pointers to buffers of multiple blocks, not just a single
block.

Reported by: GCC -Warray-parameter

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 29 2022, 7:57 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2022, 7:57 PM
jhb requested review of this revision.Nov 29 2022, 7:57 PM
jhb added a parent revision: D37546: net80211: Fix mismatches in array bounds..
Harbormaster completed remote builds in B48548: Diff 113634.Nov 29 2022, 7:57 PM
jhb added a child revision: D37548: ipfilter: Fix mismatch in array bounds..Nov 29 2022, 7:57 PM
jhb added a comment.Nov 29 2022, 8:03 PM

This one was actually not just cosmetic but a bug, if only we actually used ECB mode for anything (we don't).

imp accepted this revision.Nov 29 2022, 8:21 PM
This revision is now accepted and ready to land.Nov 29 2022, 8:21 PM
emaste accepted this revision.Dec 2 2022, 10:49 PM
Closed by commit rGd256a06fe8bd: aesni: Remove misleading array bounds for aesni_decryt_ecb. (authored by jhb). · Explain WhyDec 7 2022, 8:34 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGd256a06fe8bd: aesni: Remove misleading array bounds for aesni_decryt_ecb..
jhb added a commit: rG22cb9d3f17c4: aesni: Remove misleading array bounds for aesni_decryt_ecb..May 3 2023, 12:30 AM

Revision Contents
Changeset List

PathSize
sys/
crypto/
aesni/
2 lines

Diff 113922

View Options

sys/crypto/aesni/aesni_wrap.c

Loading...