Page MenuHomeFreeBSD
Differential D37465

growfs(7): document addition of swap partition and growfs_fstab script
ClosedPublic
Actions

Authored by karels on Nov 22 2022, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 10:09 AM
Unknown Object (File)
Thu, Apr 25, 10:48 AM
Unknown Object (File)
Wed, Apr 24, 9:33 AM
Unknown Object (File)
Wed, Apr 24, 9:33 AM
Unknown Object (File)
Jan 12 2024, 3:02 PM
Unknown Object (File)
Jan 5 2024, 10:21 PM
Unknown Object (File)
Jan 5 2024, 10:20 PM
Unknown Object (File)
Dec 23 2023, 1:17 AM
View All 28 Files
Subscribers
pauamma_gundo.com

Details

Reviewers
jmg
imp
trasz
cperciva
pauamma_gundo.com
Group Reviewers
manpages
Commits
rG0edf1fa0692e: growfs(7): document addition of swap partition and growfs_fstab script
rG4e240e55d818: growfs(7): document addition of swap partition and growfs_fstab script
Summary

Add documentation of the growfs script's new ability to add a swap
partition, expanding on the previous functionality as well. Add the
growfs_fstab helper script, which runs separately.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48630
Build 45516: arc lint + arc unit

Event Timeline

karels requested review of this revision.Nov 22 2022, 7:05 PM
karels created this revision.
Harbormaster completed remote builds in B48454: Diff 113413.Nov 22 2022, 7:05 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Nov 22 2022, 7:16 PM
pauamma_gundo.com added inline comments.
share/man/man7/growfs.7
69–82

Should that be "the next time"? (That is, the first time after it's set to YES.)

104

While here.

karels added inline comments.Nov 22 2022, 7:43 PM
share/man/man7/growfs.7
69–82

No, the script runs only on the first boot (unless it is run manually with "onestart" as described below).

104

Changed in my copy, will push it soon with any other changes.

pauamma_gundo.com accepted this revision.Nov 23 2022, 2:36 AM

With the s/on/in/ nit (fixable on commit), LGTM.

This revision is now accepted and ready to land.Nov 23 2022, 2:36 AM
karels updated this revision to Diff 113529.Nov 26 2022, 4:57 PM

growfs_fstab no longer modifies rc.conf; add example for re-growfs

Explain that if growfs added swap previously, it can be deleted to
growfs again.

This revision now requires review to proceed.Nov 26 2022, 4:57 PM
Harbormaster completed remote builds in B48506: Diff 113529.Nov 26 2022, 4:57 PM
pauamma_gundo.com accepted this revision.Nov 27 2022, 2:27 AM
This revision is now accepted and ready to land.Nov 27 2022, 2:27 AM
karels updated this revision to Diff 113886.Dec 6 2022, 5:27 PM

Update to correspond to current code in review, including new memory
size limitation.

This revision now requires review to proceed.Dec 6 2022, 5:27 PM
Harbormaster completed remote builds in B48630: Diff 113886.Dec 6 2022, 5:27 PM
pauamma_gundo.com accepted this revision.Dec 6 2022, 10:03 PM

Fixable on commit.

share/man/man7/growfs.7
44
This revision is now accepted and ready to land.Dec 6 2022, 10:03 PM
karels added inline comments.Dec 6 2022, 10:12 PM
share/man/man7/growfs.7
44

Oops, thanks for catching that.

Closed by commit rG4e240e55d818: growfs(7): document addition of swap partition and growfs_fstab script (authored by karels). · Explain WhyDec 10 2022, 7:42 PM
This revision was automatically updated to reflect the committed changes.
karels added a commit: rG4e240e55d818: growfs(7): document addition of swap partition and growfs_fstab script.
karels added a commit: rG0edf1fa0692e: growfs(7): document addition of swap partition and growfs_fstab script.Jan 13 2023, 9:01 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
1 line
82 lines

Diff 113886

View Options

share/man/man7/Makefile

Loading...
View Options

share/man/man7/growfs.7

Loading...