Page MenuHomeFreeBSD
Differential D36913

wg: Trim compat shims for versions older than current stable/13.
ClosedPublic
Actions

Authored by jhb on Oct 7 2022, 10:02 PM.
Tags
None
Referenced Files
F132537339: D36913.id111822.diff
Fri, Oct 17, 7:07 PM
F132536679: D36913.diff
Fri, Oct 17, 6:57 PM
Unknown Object (File)
Tue, Oct 14, 10:23 AM
Unknown Object (File)
Sun, Oct 12, 1:30 PM
Unknown Object (File)
Thu, Oct 9, 2:01 PM
Unknown Object (File)
Thu, Oct 9, 1:01 PM
Unknown Object (File)
Thu, Oct 9, 1:01 PM
Unknown Object (File)
Thu, Oct 9, 1:00 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
markj
kevans
Commits
rGdfbbcea39b73: wg: Trim compat shims for versions older than current stable/13.
rG854d066251a9: wg: Trim compat shims for versions older than current stable/13.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Oct 7 2022, 10:02 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 7 2022, 10:02 PM
jhb requested review of this revision.Oct 7 2022, 10:02 PM
Harbormaster completed remote builds in B47748: Diff 111572.Oct 7 2022, 10:02 PM
jhb added a parent revision: D36912: wg: Retire now unused support.h..Oct 7 2022, 10:02 PM
jhb added a child revision: D35992: wg_noise: Drop atomics for kp_can_send..Oct 7 2022, 10:03 PM
jhb removed a child revision: D35992: wg_noise: Drop atomics for kp_can_send..Oct 7 2022, 10:05 PM
emaste accepted this revision.Oct 8 2022, 2:00 AM
This revision is now accepted and ready to land.Oct 8 2022, 2:00 AM
markj accepted this revision.Oct 11 2022, 2:25 PM
markj added inline comments.
sys/dev/wg/wg_crypto.c
254

I think this could be const?

258

I'm surprised we don't have an m_extend() which simply changes the mbuf length without copying anything.

jhb mentioned this in D36909: Import the WireGuard driver from zx2c4.com..Oct 11 2022, 5:06 PM
jhb marked an inline comment as done.Oct 15 2022, 12:03 AM
jhb updated this revision to Diff 111822.Oct 15 2022, 12:21 AM
  • const (actually added earlier as well)
This revision now requires review to proceed.Oct 15 2022, 12:21 AM
Harbormaster completed remote builds in B47846: Diff 111822.Oct 15 2022, 12:21 AM
kevans accepted this revision.Oct 25 2022, 1:02 AM
This revision is now accepted and ready to land.Oct 25 2022, 1:02 AM
Closed by commit rG854d066251a9: wg: Trim compat shims for versions older than current stable/13. (authored by jhb). · Explain WhyOct 28 2022, 8:56 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG854d066251a9: wg: Trim compat shims for versions older than current stable/13..
jhb added a commit: rGdfbbcea39b73: wg: Trim compat shims for versions older than current stable/13..Nov 11 2022, 10:05 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
wg/
101 lines
67 lines
1645 lines

Diff 112353

View Options

sys/dev/wg/compat.h

Loading...
View Options

sys/dev/wg/crypto.h

Loading...
View Options

sys/dev/wg/wg_crypto.c

Loading...