Page MenuHomeFreeBSD

wg: Use plain loads and stores for so_so4 and so_so6.
AcceptedPublic

Authored by jhb on Fri, Jul 29, 4:57 PM.

Details

Reviewers
markj
Summary

Atomics are not needed to read the variables after NET_EPOCH_ENTER due
to the embedded acquire barrier in epoch_enter.

Atomics are also not needed to write the variables prior to
NET_EPOCH_WAIT due to the embedded memory fence in epoch_wait.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 46681
Build 43570: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Fri, Jul 29, 4:57 PM

Hi @jhb ,
I'm a little confused as there's no sys/dev/wg source directory in current HEAD.

Hi @jhb ,
I'm a little confused as there's no sys/dev/wg source directory in current HEAD.

This is a diff I've primarily uploaded for markj@ to review. I have a tree that imports the wg(4) driver from wireguard-freebsd into sys/dev/wg and this change (along with others in the stack) are further changes to the current wireguard-freebsd driver.

This revision is now accepted and ready to land.Mon, Aug 8, 5:13 PM